-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph-volume: honour osd_dmcrypt_key_size option #44765
Conversation
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
816262e
to
62f4478
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
902b95a
to
e4b0458
Compare
|
jenkins test ceph-volume tox |
e4b0458
to
a5d762d
Compare
|
jenkins test ceph-volume tox |
a5d762d
to
ed60768
Compare
|
jenkins test ceph-volume tox |
ed60768
to
d8ca931
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
|
jenkins test api |
|
jenkins test ceph-volume lvm centos8-filestore-dmcrypt |
9122fca
to
6313b51
Compare
d208ab8
to
9dcba39
Compare
|
jenkins test ceph-volume all |
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
1 similar comment
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
cb83851
to
a3bbe13
Compare
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
a3bbe13
to
b5536ad
Compare
|
jenkins test ceph-volume lvm centos8-bluestore-dmcrypt |
|
jenkins test ceph-volume tox |
ceph-volume doesn't honour osd_dmcrypt_key_size. It means the default size is always applied. It also changes the default value in `get_key_size_from_conf()` From cryptsetup manpage: > For XTS mode you can optionally set a key size of 512 bits with the -s option. Using more than 512bits will end up with the following error message: ``` Key size in XTS mode must be 256 or 512 bits. ``` Fixes: https://tracker.ceph.com/issues/54006 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
this adds some unit tests in order to cover `luks_format()` and `luks_open()` in `util/encryption.py`. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Since recent move from CentOS 8 to CentOS Stream 8, let's do the same here. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
When `ceph-volume lvm trigger` is called with an OSD where the tag `ceph.cluster_name` is not 'ceph', it fails. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
b5536ad
to
5ac1ec6
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
|
jenkins test ceph-volume batch centos8-filestore-mixed_type_explicit |
|
jenkins test ceph-volume lvm centos8-filestore-create |
|
jenkins test ceph-volume lvm centos8-filestore-create |
|
ceph-volume doesn't honour osd_dmcrypt_key_size.
It means the default size is always applied.
Fixes: https://tracker.ceph.com/issues/54006
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com