Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume: honour osd_dmcrypt_key_size option #44765

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

guits
Copy link
Contributor

@guits guits commented Jan 25, 2022

ceph-volume doesn't honour osd_dmcrypt_key_size.
It means the default size is always applied.

Fixes: https://tracker.ceph.com/issues/54006

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

@guits guits requested a review from a team as a code owner January 25, 2022 09:30
@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume all

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume all

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Jan 25, 2022

jenkins test ceph-volume all

@guits
Copy link
Contributor Author

guits commented Jan 26, 2022

jenkins test api

@guits
Copy link
Contributor Author

guits commented Jan 26, 2022

jenkins test ceph-volume lvm centos8-filestore-dmcrypt

@guits guits force-pushed the guits-fix-cve-cv branch 4 times, most recently from 9122fca to 6313b51 Compare January 26, 2022 10:47
@guits guits force-pushed the guits-fix-cve-cv branch 3 times, most recently from d208ab8 to 9dcba39 Compare February 9, 2022 16:05
@github-actions github-actions bot added the rgw label Feb 9, 2022
@guits
Copy link
Contributor Author

guits commented Feb 9, 2022

jenkins test ceph-volume all

@guits guits removed the rgw label Feb 9, 2022
@guits
Copy link
Contributor Author

guits commented Feb 9, 2022

jenkins test ceph-volume lvm centos8-bluestore-dmcrypt

1 similar comment
@guits
Copy link
Contributor Author

guits commented Feb 9, 2022

jenkins test ceph-volume lvm centos8-bluestore-dmcrypt

@guits
Copy link
Contributor Author

guits commented Feb 9, 2022

jenkins test ceph-volume lvm centos8-bluestore-dmcrypt

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume lvm centos8-bluestore-dmcrypt

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume tox

ceph-volume doesn't honour osd_dmcrypt_key_size.
It means the default size is always applied.

It also changes the default value in `get_key_size_from_conf()`

From cryptsetup manpage:

> For XTS mode you can optionally set a key size of 512 bits with the -s option.

Using more than 512bits will end up with the following error message:

```
Key size in XTS mode must be 256 or 512 bits.
```

Fixes: https://tracker.ceph.com/issues/54006

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
this adds some unit tests in order to cover `luks_format()` and `luks_open()`
in `util/encryption.py`.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
Since recent move from CentOS 8 to CentOS Stream 8, let's do the same here.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
When `ceph-volume lvm trigger` is called with an OSD where the tag
`ceph.cluster_name` is not 'ceph', it fails.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume tox

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume all

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume batch centos8-filestore-mixed_type_explicit

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume lvm centos8-filestore-create

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

jenkins test ceph-volume lvm centos8-filestore-create

@guits
Copy link
Contributor Author

guits commented Feb 10, 2022

failed:  0
dead:    0
running: 0
waiting: 0
queued:  0
passed:  63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants