Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: osd/OSD: Log aggregated slow ops detail to cluster logs #44771

Merged
merged 1 commit into from Mar 25, 2022
Merged

pacific: osd/OSD: Log aggregated slow ops detail to cluster logs #44771

merged 1 commit into from Mar 25, 2022

Conversation

pdvian
Copy link

@pdvian pdvian commented Jan 25, 2022

backport tracker: https://tracker.ceph.com/issues/53944

backport of #43732
parent tracker: https://tracker.ceph.com/issues/52424

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@pdvian pdvian added this to the pacific milestone Jan 25, 2022
@pdvian pdvian added the core label Jan 25, 2022
neha-ojha
neha-ojha reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@neha-ojha neha-ojha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdvian please don't remove the Conflicts: section from the commit message, and add an explanation for how the conflicts were resolved

osd/OSD: Log aggregated slow ops detail to cluster logs
a1156c9 
Slow requests can overwhelm a cluster log with every slow op in
detail and also fills up the monitor db. Instead, log slow ops
details in aggregated format.

Fixes: https://tracker.ceph.com/issues/52424

Signed-off-by: Prashant D <pdhange@redhat.com>
(cherry picked from commit 9319dc9)

Conflicts:
       src/common/options/osd.yaml.in: Removed osd.yaml.in as
                 pacific release does not support options in
                 yaml format. Added new config
                 'osd_aggregated_slow_ops_logging' to common/options.
@amathuria
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/yuriw-2022-03-23_14:51:02-rados-wip-yuri4-testing-2022-03-21-1648-pacific-distro-default-smithi/

Unrelated failures tracked in:

https://tracker.ceph.com/issues/54071 - rados/cephadm/osds: Invalid command: missing required parameter hostname()
https://tracker.ceph.com/issues/53501 - Exception when running 'rook' task.
https://tracker.ceph.com/issues/53939 - ceph-nfs-upgrade, pacific: Upgrade Paused due to UPGRADE_REDEPLOY_DAEMON: Upgrading daemon osd.0 on host smithi103 failed
https://tracker.ceph.com/issues/50893 - osd/PrimaryLogPG.cc: FAILED ceph_assert(attrs || !recovery_state.get_pg_log().get_missing().is_missing(soid) || (it_objects != recovery_state.get_pg_log().get_log().objects.end() && it_objects->second->op == pg_log_entry_t::LOST_REVERT))
https://tracker.ceph.com/issues/54406 - cephadm/mgr-nfs-upgrade: cluster [WRN] overall HEALTH_WARN no active mgr

@yuriw yuriw merged commit 67dc700 into ceph:pacific Mar 25, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@ronen-fr ronen-fr Awaiting requested review from ronen-fr

Assignees
No one assigned
Labels
common core needs-qa wip-yuri4-testing
Projects
None yet
Milestone
pacific
4 participants
@pdvian @amathuria @neha-ojha @yuriw