mgr/cephadm: Show an error when invalid format #45023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adk3798
reviewed
Feb 14, 2022
Fixes: https://tracker.ceph.com/issues/54198 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
rkachach
force-pushed
the
fix_issue_54198
branch
from
3b93c62
to
d2fa22f
Compare
adk3798
approved these changes
Feb 21, 2022
| @@ -115,6 +117,8 @@ def to_yaml_n(objs: list) -> list: | |||
| if many: | |||
| return yaml.dump_all(to_yaml(copy), default_flow_style=False) | |||
| return yaml.dump(to_yaml(copy), default_flow_style=False) | |||
| elif format == Format.xml or format == Format.xml_pretty: | |||
| raise OrchestratorError(f"format '{format.name}' is not implemented.") | |||
There was a problem hiding this comment.
Suggested change
| raise OrchestratorError(f"format '{format.name}' is not implemented.") | |
| raise OrchestratorError(f"format '{format.name}' is not implemented for 'ceph orch' commands.") |
NIT, technically this format is implemented in other areas of ceph. It's ceph orch commands specifically that we mean here.
|
Most failures tracked by https://tracker.ceph.com/issues/54304 Also a couple pre-test failures running apt-get commands and one instance where one of the osds created in a startup task never came up. 20+ tests ran the same startup task in the same run successfully so thinking it's just a one off. |
rkachach
added a commit
to rkachach/ceph
that referenced
this pull request
Mar 2, 2022
backport of: ceph#45023 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
14 tasks
13 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/54198
Signed-off-by: Redouane Kachach rkachach@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox