mgr/dashboard: OSD Creation Workflow initial works #45116

nizamial09 · 2022-02-22T10:40:44Z

Depends on #45190
This is kind of a skeleton PR. As per the design of the feature, backend needs to provide frontend all the data's and UI will just present it to the user. So I'll wait for the backend to setup first to adapt the frontend. Currently, the frontend design is just static.

Also, the current OSD Creation is moved to the Advanced Mode Option

Introducing the Cost/Capacity Optimized deployment option
Used bootstrap accordion
Adapted the e2e but not written new tests for the deployment option

Deployment Scenarios

Advanced Mode

View from Cluster Expansion wizard

Fixes: https://tracker.ceph.com/issues/54340
Fixes: https://tracker.ceph.com/issues/54563
Signed-off-by: Nizamudeen A nia@redhat.com
Co-authored-by: Sarthak0702 sarthak.0702@gmail.com

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

nizamial09 · 2022-02-22T10:42:00Z

jenkins test dashboard cephadm

nizamial09 · 2022-02-22T10:42:07Z

jenkins test dashboard

nizamial09 · 2022-02-22T17:13:24Z

Jenkins retest this please

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html

github-actions · 2022-03-16T13:33:14Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

nizamial09 · 2022-03-23T07:13:02Z

@sunilangadi2 Can you also test this one? keep in mind as of now only the cost-capacity optimized option is testable.

src/pybind/mgr/dashboard/controllers/osd.py

src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/osds.po.ts

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/cluster.module.ts

...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.ts

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.ts

src/pybind/mgr/dashboard/frontend/src/app/shared/models/osd-deployment-options.ts

src/pybind/mgr/dashboard/frontend/src/styles/ceph-custom/_basics.scss

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.ts

pereman2

Is this type of behaviour expected in the accordion component?

Ceph_.Expand.Cluster.mp4

src/pybind/mgr/dashboard/frontend/src/app/shared/api/osd.service.ts

src/pybind/mgr/dashboard/controllers/osd.py

src/pybind/mgr/dashboard/tests/test_osd.py

src/pybind/mgr/dashboard/frontend/src/app/shared/models/osd-deployment-options.ts

epuertat

Nice progress @nizamial09 ! More feedback from my end :D Have a nice weekend!

src/pybind/mgr/dashboard/controllers/osd.py

epuertat · 2022-04-01T16:46:03Z

src/pybind/mgr/dashboard/controllers/osd.py

+            OsdDeploymentOptions.COST_CAPACITY.value:
+                DeploymentOption(OsdDeploymentOptions.COST_CAPACITY.value),


Just a comment on code: don't feel this hard to read. First of all, there are 2 classes with very similar names (OsdDeploymentOptions and DeploymentOption), and I'd expect that both are connected (the plural "...Options" is just an list containing multiple "DeploymentOption"s), but that's not the case.

If you ever end up writing a chunk of code that is as unintuitive to read as this one, please consider that as a smell that something going wrong.

Changed the function name for clarity

src/pybind/mgr/dashboard/controllers/osd.py

...ind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.scss

...ybind/mgr/dashboard/frontend/src/app/ceph/cluster/create-cluster/create-cluster.component.ts

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html

epuertat · 2022-04-01T17:21:04Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.spec.ts

+  const deploymentOptions: DeploymentOptions = {
+    options: {
+      cost_capacity: {
+        name: OsdDeploymentOptions.COST_CAPACITY,
+        available: true,
+        capacity: 0,
+        used: 0,
+        hdd_used: 0,
+        ssd_used: 0,
+        nvme_used: 0,
+        option_name: 'Cost/Capacity-optimized',
+        msg: 'All the available HDDs are selected'
+      },


All the things mentioned for the back-end data structs apply here, and they're more evident since most of these fields are not needed in the UI (ssd_used?), only the recommended option, right? That means that we're coupling in the back-end 2 or more different data classes.

The class we'd need here is what, at back-end, I defined as:

# Named tuples allows us to quickly prototype immutable objects with initialization, defaults and asdict() class OsdDeploymentOption(NamedTuple): id: str title: str desc: str

If we need some extra data (like total capacity, or number of disks), we could append some "hints" to this class (e.g.: the getDeploymentRecommendation() service returns the recommended DeploymentOption + extras: available + capacity + etc.).

I think we decided on this in the previous PR #45190, and fields like hdd_used etc are needed on the later iterations when we try to fill the pie chart in the frontend (to visualize the storage used infos).

nizamial09 · 2022-04-05T10:54:38Z

Is this type of behaviour expected in the accordion component?

Yup, https://getbootstrap.com/docs/4.6/components/collapse/#accordion-example. But I removed the focus so we don't have a broken border when clicking it. @pereman2

src/pybind/mgr/dashboard/controllers/osd.py

nizamial09 · 2022-04-07T18:25:33Z

jenkins test dashboard

avanthakkar · 2022-03-24T10:12:35Z

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html

-            </div>
-          </div>
-        </fieldset>
+                <!-- DB slots -->


I'm not sure what these extra spaces for..maybe can be removed?

@avanthakkar Those are indendation changes to proper align it and it was not a mistake. If I remove it it will be misaligned with the above and below lines.

epuertat · 2022-04-26T10:30:24Z

@nizamial09 based on the above screenshot it looks like the Advanced mode is "additional" to the first 3 modes, while in reality it should be exclusive (either you select the simple modes or the advanced modes). Wouldn't it be better to display that in a 4th option?

nizamial09 · 2022-04-26T10:36:49Z

@nizamial09 based on the above screenshot it looks like the Advanced mode is "additional" to the first 3 modes, while in reality it should be exclusive (either you select the simple modes or the advanced modes). Wouldn't it be better to display that in a 4th option?

@epuertat But either the Advanced mode or the Deployment option is visible at a time. If the user clicks on ADvanced mode then the Deployment option will be hidden. (The Feature on the other hand will be always shown)

src/pybind/mgr/dashboard/services/osd.py

src/pybind/mgr/dashboard/controllers/osd.py

avanthakkar

LGTM!

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html

sunilangadi2

Thanks, @nizamial09 ! changes look good to me.

Introducing the Cost/Capacity Optimized deployment option Used bootstrap accordion Adapted the e2e but not written new tests for the deployment option Fixes: https://tracker.ceph.com/issues/54340 Fixes: https://tracker.ceph.com/issues/54563 Signed-off-by: Nizamudeen A <nia@redhat.com> Signed-off-by: Sarthak0702 <sarthak.0702@gmail.com>

nizamial09 · 2022-04-27T09:52:34Z

jenkins test make check

nizamial09 · 2022-04-27T10:30:02Z

jenkins test make check

github-actions bot added dashboard pybind labels Feb 22, 2022

nizamial09 requested a review from pereman2 February 22, 2022 10:41

nizamial09 added this to In progress in Dashboard via automation Feb 22, 2022

nizamial09 changed the title ~~mgr/dashboard: OSD Creation Workflow initial works~~ mgr/dashboard: OSD Creation Workflow initial works Feb 22, 2022

sunilangadi2 reviewed Feb 23, 2022

View reviewed changes

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html Outdated Show resolved Hide resolved

github-actions bot added the needs-rebase label Mar 16, 2022

nizamial09 force-pushed the osd-creation-cost-optimized branch from bdd11d0 to 3b4905f Compare March 21, 2022 13:30

github-actions bot removed the needs-rebase label Mar 21, 2022

Sarthak0702 self-requested a review March 21, 2022 18:48

nizamial09 force-pushed the osd-creation-cost-optimized branch from 3b4905f to f809888 Compare March 22, 2022 09:10

nizamial09 marked this pull request as ready for review March 22, 2022 09:12

nizamial09 requested a review from a team March 22, 2022 09:12

nizamial09 requested a review from a team as a code owner March 22, 2022 09:12

nizamial09 requested review from aaSharma14, avanthakkar and epuertat March 22, 2022 09:13

nizamial09 force-pushed the osd-creation-cost-optimized branch from f809888 to f27ca14 Compare March 23, 2022 06:23

epuertat requested changes Mar 29, 2022

View reviewed changes

Dashboard automation moved this from In progress to Review in progress Mar 29, 2022

nizamial09 force-pushed the osd-creation-cost-optimized branch from f27ca14 to cd9e70e Compare April 1, 2022 09:13

nizamial09 requested a review from epuertat April 1, 2022 09:59

pereman2 requested changes Apr 1, 2022

View reviewed changes

epuertat requested changes Apr 1, 2022

View reviewed changes

nizamial09 force-pushed the osd-creation-cost-optimized branch from cd9e70e to 8f00545 Compare April 5, 2022 10:45

nizamial09 requested review from pereman2, epuertat and sunilangadi2 April 5, 2022 10:54

nizamial09 force-pushed the osd-creation-cost-optimized branch from 8f00545 to b0dfa4e Compare April 6, 2022 06:32

aaSharma14 added the needs-review label Apr 6, 2022

sunilangadi2 requested changes Apr 7, 2022

View reviewed changes

src/pybind/mgr/dashboard/controllers/osd.py Show resolved Hide resolved

nizamial09 force-pushed the osd-creation-cost-optimized branch 3 times, most recently from c8d034a to d3714c5 Compare April 7, 2022 17:01

nizamial09 requested a review from sunilangadi2 April 7, 2022 17:01

avanthakkar reviewed Apr 19, 2022

View reviewed changes

epuertat approved these changes Apr 26, 2022

View reviewed changes

src/pybind/mgr/dashboard/services/osd.py Outdated Show resolved Hide resolved

src/pybind/mgr/dashboard/controllers/osd.py Outdated Show resolved Hide resolved

nizamial09 force-pushed the osd-creation-cost-optimized branch from d3714c5 to 6dc219b Compare April 26, 2022 14:30

avanthakkar approved these changes Apr 26, 2022

View reviewed changes

Sarthak0702 approved these changes Apr 26, 2022

View reviewed changes

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-form/osd-form.component.html Outdated Show resolved Hide resolved

sunilangadi2 approved these changes Apr 27, 2022

View reviewed changes

nizamial09 moved this from Review in progress to Ready-to-merge in Dashboard Apr 27, 2022

nizamial09 force-pushed the osd-creation-cost-optimized branch from 6dc219b to e3fe284 Compare April 27, 2022 08:56

epuertat merged commit 1330ffc into ceph:feature-54330-osd-creation-workflow Apr 27, 2022
10 of 11 checks passed

Dashboard automation moved this from Ready-to-merge to Done Apr 27, 2022

epuertat deleted the osd-creation-cost-optimized branch April 27, 2022 12:07

mgr/dashboard: OSD Creation Workflow initial works #45116

mgr/dashboard: OSD Creation Workflow initial works #45116

nizamial09 commented Feb 22, 2022 •

edited

nizamial09 commented Feb 22, 2022

nizamial09 commented Feb 22, 2022

nizamial09 commented Feb 22, 2022

github-actions bot commented Mar 16, 2022

nizamial09 commented Mar 23, 2022

pereman2 left a comment

epuertat left a comment

epuertat Apr 1, 2022

nizamial09 Apr 5, 2022

epuertat Apr 1, 2022

nizamial09 Apr 5, 2022

nizamial09 commented Apr 5, 2022

nizamial09 commented Apr 7, 2022

avanthakkar Mar 24, 2022

nizamial09 Apr 21, 2022

nizamial09 Apr 21, 2022

epuertat commented Apr 26, 2022

nizamial09 commented Apr 26, 2022

avanthakkar left a comment

sunilangadi2 left a comment

nizamial09 commented Apr 27, 2022

nizamial09 commented Apr 27, 2022

		OsdDeploymentOptions.COST_CAPACITY.value:
		DeploymentOption(OsdDeploymentOptions.COST_CAPACITY.value),

mgr/dashboard: OSD Creation Workflow initial works #45116

mgr/dashboard: OSD Creation Workflow initial works #45116

Conversation

nizamial09 commented Feb 22, 2022 • edited

Checklist

nizamial09 commented Feb 22, 2022

nizamial09 commented Feb 22, 2022

nizamial09 commented Feb 22, 2022

github-actions bot commented Mar 16, 2022

nizamial09 commented Mar 23, 2022

pereman2 left a comment

Choose a reason for hiding this comment

epuertat left a comment

Choose a reason for hiding this comment

epuertat Apr 1, 2022

Choose a reason for hiding this comment

nizamial09 Apr 5, 2022

Choose a reason for hiding this comment

epuertat Apr 1, 2022

Choose a reason for hiding this comment

nizamial09 Apr 5, 2022

Choose a reason for hiding this comment

nizamial09 commented Apr 5, 2022

nizamial09 commented Apr 7, 2022

avanthakkar Mar 24, 2022

Choose a reason for hiding this comment

nizamial09 Apr 21, 2022

Choose a reason for hiding this comment

nizamial09 Apr 21, 2022

Choose a reason for hiding this comment

epuertat commented Apr 26, 2022

nizamial09 commented Apr 26, 2022

avanthakkar left a comment

Choose a reason for hiding this comment

sunilangadi2 left a comment

Choose a reason for hiding this comment

nizamial09 commented Apr 27, 2022

nizamial09 commented Apr 27, 2022

nizamial09 commented Feb 22, 2022 •

edited