pacific: mgr/volumes: A few mgr volumes pacific backports #45205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check |
ajarr
approved these changes
Mar 14, 2022
|
@yuriw this PR is meant for pacific. Why was this PR added to octopus milestone instead of pacific? |
|
jenkins test make check |
Fixes: https://tracker.ceph.com/issues/54121 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit 96c7963)
The file quota attribute 'ceph.quota.max_files' is not inherited to the cloned subvolume. This patch fixes the same. Fixes: https://tracker.ceph.com/issues/54121 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit 72671c8)
Fixes: https://tracker.ceph.com/issues/54099 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit 95a83ef)
The subvolumegroup ls listed '_deleting' directory which is internal to 'mgr/volumes' and should not be listed as a subvolumegroup. This patch fixes the same by filtering it. Fixes: https://tracker.ceph.com/issues/54099 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit a125b0e)
This is the regression caused by commit 18b85c5. The 'set_attrs' function sets the uid/gid of the group to the subvolume if uid/gid is not passed. The attrs of the clone should match the source snapshot. Hence, don't use the 'set_attrs' function to set only the quota attrs for the clone. Fixes: https://tracker.ceph.com/issues/54066 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit b3c9e6b)
kotreshhr
force-pushed
the
pacific-mgr-volumes-backports-0
branch
from
b3834d2
to
4b2aff8
Compare
vshankar
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Tracker: https://tracker.ceph.com/issues/54121
Parent PR: mgr/volumes: Inherit file quota attr to clone #44873
Parent Tracker: https://tracker.ceph.com/issues/54099
Parent PR: mgr/volumes: Fix subvolumegroup ls #44854
Parent Tracker: https://tracker.ceph.com/issues/54066
Parent PR: mgr/volumes: Fix clone uid/gid mismatch #44970
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox