Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: checking service name before removal #45314

Merged
merged 1 commit into from Mar 25, 2022

Conversation

rkachach
Copy link
Contributor

@rkachach rkachach commented Mar 9, 2022

Fixes: https://tracker.ceph.com/issues/54503

Signed-off-by: Redouane Kachach rkachach@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@rkachach rkachach requested a review from a team as a code owner March 9, 2022 13:26
@rkachach
Copy link
Contributor Author

jenkins test make check

@rkachach rkachach requested a review from adk3798 March 10, 2022 17:14
src/pybind/mgr/cephadm/module.py Outdated Show resolved Hide resolved
Fixes: https://tracker.ceph.com/issues/54503

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
@adk3798
Copy link
Contributor

adk3798 commented Mar 24, 2022

http://pulpito.front.sepia.ceph.com/adking-2022-03-23_02:54:35-orch:cephadm-wip-adk-testing-2022-03-22-2000-distro-basic-smithi/

2 Failures caused by wrong error code from host add command due to another PR included in the run

@adk3798
Copy link
Contributor

adk3798 commented Mar 24, 2022

jenkins test api

@adk3798 adk3798 merged commit 8cc6cbc into ceph:master Mar 25, 2022
10 of 12 checks passed
@rkachach rkachach deleted the fix_issue_54503 branch March 25, 2022 14:16
@adk3798 adk3798 mentioned this pull request Mar 30, 2022
14 tasks
@adk3798 adk3798 mentioned this pull request Apr 27, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants