Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix wrong pg status processing #45360

Merged
merged 1 commit into from Mar 22, 2022
Merged

mgr/dashboard: fix wrong pg status processing #45360

merged 1 commit into from Mar 22, 2022

Conversation

epuertat
Copy link
Member

@epuertat epuertat commented Mar 11, 2022 •
edited

Before

image

After

image

To reproduce:

  1. Create RBD image
  2. Run rbd bench-write <image> to populate the image
  3. Create snapshot from that image
  4. Run rbd bench-write <image> again
  5. Delete the snapshot

That will cause some PGs to become snaptrim and snaptrim_wait.

Fixes: https://tracker.ceph.com/issues/54481
Signed-off-by: Ernesto Puerta epuertat@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@epuertat epuertat requested a review from a team as a code owner March 11, 2022 16:33
@epuertat epuertat requested review from sunilangadi2 and Sarthak0702 and removed request for a team March 11, 2022 16:33
@github-actions github-actions bot added this to In progress in Dashboard Mar 11, 2022
@epuertat
mgr/dashboard: fix wrong pg status processing
206dd9d 
Fixes: https://tracker.ceph.com/issues/54481
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
sunilangadi2
sunilangadi2 approved these changes Mar 14, 2022
View reviewed changes
Copy link

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Dashboard automation moved this from In progress to Reviewer approved Mar 14, 2022
@epuertat
Copy link
Member Author

jenkins test make check

@epuertat
Copy link
Member Author

jenkins test api

@epuertat
Copy link
Member Author

jenkins test make check arm64

@epuertat
Copy link
Member Author

jenkins test make check

@epuertat epuertat merged commit c3127f3 into ceph:master Mar 22, 2022
@epuertat epuertat deleted the fix-54481-master branch March 22, 2022 12:07
Dashboard automation moved this from Reviewer approved to Done Mar 22, 2022
This was referenced May 11, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilangadi2 sunilangadi2 sunilangadi2 approved these changes

@avanthakkar avanthakkar avanthakkar approved these changes

@Sarthak0702 Sarthak0702 Sarthak0702 approved these changes

Assignees
No one assigned
Labels
dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
4 participants
@epuertat @sunilangadi2 @avanthakkar @Sarthak0702