Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: generate new tag for object when setting object attrs #4571

Merged
merged 2 commits into from May 6, 2015

Conversation

Projects
None yet
3 participants
@oritwas
Copy link
Contributor

commented May 6, 2015

rgw: generate new tag for object when setting object attrs
cls_rgw: use multimap to keep pending operations in bucket index

Fixes: #11256

yehudasa added some commits Mar 27, 2015

rgw: generate new tag for object when setting object attrs
Fixes: #11256
Backport: firefly, hammer

Beforehand we were reusing the object's tag, which is problematic as
this tag is used for bucket index updates, and we might be clobbering a
racing update (like object removal).

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
cls_rgw: use multimap to keep pending operations in bucket index
Fixes: #11256
Multiple concurrent requests might be sent using the same tag, need the
entry map to be able to hold multiple entries.

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

@ghost ghost added bug fix rgw labels May 6, 2015

@ghost ghost assigned yehudasa May 6, 2015

@yehudasa

This comment has been minimized.

Copy link
Member

commented May 6, 2015

@dachary the hammer version also had a third commit: 5559462. I'm not 100% sure why it compiled without it, could be that it's not needed for firefly.

@ghost

This comment has been minimized.

Copy link

commented May 6, 2015

@yehudasa it looks like the kind of thing that would fail at compile time or not at all

yehudasa added a commit that referenced this pull request May 6, 2015

Merge pull request #4571 from ceph/wip-11256-firefly
Wip 11256 firefly

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>

@yehudasa yehudasa merged commit df053b8 into firefly May 6, 2015

@ghost ghost changed the title Wip 11256 firefly rgw: generate new tag for object when setting object attrs Jul 14, 2015

@yehudasa yehudasa deleted the wip-11256-firefly branch Oct 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.