New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Change variable length array of std::strings (not legal in C++) to std::vector<std::string> #4583

Merged
merged 1 commit into from Jul 25, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented May 6, 2015

Variable length array of std::strings (not legal in C++) changed to s…
…td::vector<std::string>

Signed-off-by: Daniel J. Hofmann <daniel@trvx.org>
(cherry picked from commit 08a4e88)

@ghost ghost added cleanup core rgw and removed core labels May 6, 2015

@ghost ghost self-assigned this May 6, 2015

@ghost ghost added this to the firefly milestone May 6, 2015

@ghost ghost assigned smithfarm and unassigned ghost Jun 2, 2015

@ghost ghost changed the title from Change variable length array of std::strings (not legal in C++) to std::vector<std::string> to rgw: Change variable length array of std::strings (not legal in C++) to std::vector<std::string> Jul 21, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 24, 2015

@dachary This has passed first round of integration testing as detailed in http://tracker.ceph.com/issues/11644

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 24, 2015

@liewegas This PR has passed integration tests. Is it OK to merge? I'm asking you because you merged the master commit that this is a backport of: #1768

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 24, 2015

yep, looks good to me!

smithfarm added a commit that referenced this pull request Jul 25, 2015

Merge pull request #4583 from SUSE/wip-11542-firefly
rgw: Change variable length array of std::strings (not legal in C++) to std::vector<std::string>

Reviewed-by: Sage Weil <sage@redhat.com>

@smithfarm smithfarm merged commit abe6c03 into ceph:firefly Jul 25, 2015

@smithfarm smithfarm deleted the SUSE:wip-11542-firefly branch Jul 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment