mgr/cephadm: allow setting insecure_skip_verify for alertmanager

[adk3798]

Fixes: https://tracker.ceph.com/issues/55272

Signed-off-by: Adam King adking@redhat.com

Changelog: Changed it from always applying this setting to only applying it if an "insecure" property is set to true in the spec

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[adk3798]

http://pulpito.ceph.com/adking-2022-04-13_05:16:48-orch:cephadm-wip-adk-testing-2022-04-12-2231-distro-basic-smithi/

2 Failures

• https://tracker.ceph.com/issues/44587
• ceph-volume lvm batch failure ERROR: error creating empty object store in /var/lib/ceph/osd/ceph-3/: (5) Input/output error that may be a faulty hardware thing, we're not sure. Did a rerun of the osds tests https://pulpito.ceph.com/adking-2022-04-13_13:12:12-orch:cephadm:osds-wip-adk-testing-2022-04-12-2231-distro-basic-smithi/ and the test that failed in the last run passed and the one test that did fail is due to https://tracker.ceph.com/issues/49287

To summarize, run was passing. Will start tracking this type of lvm batch failure to see if it happens on the same hosts (which would imply a possible hardware issue) in https://tracker.ceph.com/issues/55319

[adk3798]

jenkins test make check

[adk3798]

https://pulpito.ceph.com/adking-2022-04-15_05:56:09-orch:cephadm-wip-adk-testing-2022-04-14-1844-distro-basic-smithi/

1 infra failure reimaging machines

[p-se]

lgtm

[epuertat]

hi @adk3798: is this going to be backported to quincy-pacific? (as cephadm doesn't follow the regular Ceph backport process it's not clear to me)

[adk3798]

hi @adk3798: is this going to be backported to quincy-pacific? (as cephadm doesn't follow the regular Ceph backport process it's not clear to me)

already backported this to pacific. Quincy backport will happen soon as part of a large batch of cephadm things to backport there once the initial release completes.