Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: fix ssl cert validation for ingress service creation #46108

Merged
merged 2 commits into from May 6, 2022
Merged

mgr/dashboard: fix ssl cert validation for ingress service creation #46108

merged 2 commits into from May 6, 2022

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented May 2, 2022 •
edited

The private_key field for ingress service creation isn't required, just the ssl_cert in .PEM format is enough.

Fixes: https://tracker.ceph.com/issues/55511
Signed-off-by: Avan Thakkar athakkar@redhat.com

Before:
Screenshot from 2022-05-02 14-13-14

After:
Screenshot from 2022-05-02 14-11-23

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@avanthakkar avanthakkar requested a review from a team May 2, 2022 08:06
@avanthakkar avanthakkar added this to In progress in Dashboard via automation May 2, 2022
@avanthakkar avanthakkar requested review from Sarthak0702 and aaSharma14 and removed request for a team May 2, 2022 08:06
@avanthakkar
mgr/dashboard: add unit tests for ingress service
2c15c26 
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
@avanthakkar avanthakkar requested a review from a team as a code owner May 2, 2022 09:04
@avanthakkar avanthakkar added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label May 2, 2022
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@avanthakkar
Copy link
Contributor Author

jenkins test api

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

Dashboard automation moved this from In progress to Reviewer approved May 6, 2022
sunilangadi2
sunilangadi2 approved these changes May 6, 2022
View reviewed changes
Copy link

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @avanthakkar for the quick fix,
Changes look good to me based on the attached screenshot,
@epuertat can this PR be merged and get in downstream,pacific 5.1z1?

@epuertat
Copy link
Member

epuertat commented May 6, 2022

Thanks @avanthakkar for the quick fix, Changes look good to me based on the attached screenshot, @epuertat can this PR be merged and get in downstream,pacific 5.1z1?

Makes sense @sunilangadi2. This comes from a downstream BZ, right?

@epuertat epuertat merged commit a7e5751 into ceph:master May 6, 2022
13 checks passed
Dashboard automation moved this from Reviewer approved to Done May 6, 2022
@epuertat epuertat deleted the fix-ingress-ssl-cert-validation branch May 6, 2022 11:52
@sunilangadi2
Copy link

Thanks @avanthakkar for the quick fix, Changes look good to me based on the attached screenshot, @epuertat can this PR be merged and get in downstream,pacific 5.1z1?

Makes sense @sunilangadi2. This comes from a downstream BZ, right?

Yes, Correct.

This was referenced May 9, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilangadi2 sunilangadi2 sunilangadi2 approved these changes

@epuertat epuertat epuertat approved these changes

@Sarthak0702 Sarthak0702 Awaiting requested review from Sarthak0702 Sarthak0702 was automatically assigned from ceph/dashboard

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14 aaSharma14 was automatically assigned from ceph/dashboard

@nizamial09 nizamial09 Awaiting requested review from nizamial09

Assignees
No one assigned
Labels
dashboard pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
3 participants
@avanthakkar @epuertat @sunilangadi2