Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: Disable external snapshots in grafana #46159

Merged

Conversation

aaSharma14
Copy link
Contributor

This PR intends to disable the external snapshots in grafana to reduce security threats

Signed-off-by: Aashish Sharma aasharma@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@aaSharma14 aaSharma14 requested a review from epuertat May 5, 2022 08:25
@aaSharma14 aaSharma14 requested a review from a team as a code owner May 5, 2022 08:25
@aaSharma14 aaSharma14 added this to In progress in Dashboard via automation May 5, 2022
Dashboard automation moved this from In progress to Reviewer approved May 5, 2022
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @aaSharma14

@aaSharma14 aaSharma14 force-pushed the disable-external-grafana-snapshots branch from 40cce44 to 58b7ba5 Compare May 6, 2022 07:32
This PR intends to disable the external snapshots in grafana to reduce security threats

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14 aaSharma14 force-pushed the disable-external-grafana-snapshots branch from 58b7ba5 to 334f4e1 Compare May 6, 2022 08:01
@aaSharma14
Copy link
Contributor Author

jenkins test api

@aaSharma14
Copy link
Contributor Author

jenkins test windows

@aaSharma14 aaSharma14 moved this from Reviewer approved to Ready-to-merge in Dashboard May 10, 2022
@epuertat epuertat merged commit 84f7da7 into ceph:master May 10, 2022
12 checks passed
Dashboard automation moved this from Ready-to-merge to Done May 10, 2022
@epuertat epuertat deleted the disable-external-grafana-snapshots branch May 10, 2022 11:48
@adk3798 adk3798 mentioned this pull request May 21, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
5 participants