Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: osd/PGLog.cc: Trim duplicates by number of entries #46251

Merged
merged 2 commits into from May 24, 2022
Merged

quincy: osd/PGLog.cc: Trim duplicates by number of entries #46251

merged 2 commits into from May 24, 2022

Conversation

rzarzynski
Copy link
Contributor

Backport of #45529.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@NitzanMordhai @rzarzynski
tools/ceph_objectstore_took: Add duplicate entry trimming
5245fb3 
Adding duplicate entries trimming to trim-pg-log opertion, we will use the exist
PGLog trim function to find out the set of entries\dup entries that we suppose to
trim. to use it we need to build the PGLog from disk.

Fixed: https://tracker.ceph.com/issues/53729
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
(cherry picked from commit 9fb7ec6)
@NitzanMordhai @rzarzynski
osd/PGLog.cc: Trim duplicates by number of entries
3ff0df6 
PGLog needs to trim duplicates by the number of entries rather than the versions. That way, we prevent unbounded duplicate growth.

Fixed: https://tracker.ceph.com/issues/53729
Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
(cherry picked from commit 0d253bc)
@rzarzynski rzarzynski added this to the quincy milestone May 12, 2022
@ljflores
Copy link
Contributor

jenkins test windows

@ljflores
Copy link
Contributor

jenkins test api

@ljflores
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/yuriw-2022-05-19_18:50:25-rados-wip-yuri4-testing-2022-05-19-0831-quincy-distro-default-smithi/

Failures, unrelated:
1. https://tracker.ceph.com/issues/52321
2. https://tracker.ceph.com/issues/52657
3. https://tracker.ceph.com/issues/51076

Details:
1. qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Ceph - Orchestrator
2. MOSDPGLog::encode_payload(uint64_t): Assertion `HAVE_FEATURE(features, SERVER_NAUTILUS)' - Ceph - RADOS
3. "wait_for_recovery: failed before timeout expired" during thrashosd test with EC backend. - Ceph - RADOS

@yuriw yuriw merged commit 4534ee1 into ceph:quincy May 24, 2022
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

@NitzanMordhai NitzanMordhai Awaiting requested review from NitzanMordhai

Assignees
No one assigned
Labels
core needs-qa tests wip-yuri4-testing
Projects
None yet
Milestone
quincy
5 participants
@rzarzynski @ljflores @neha-ojha @yuriw @NitzanMordhai