Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: test: No direct use of nose #46254

Merged
merged 3 commits into from May 24, 2022
Merged

quincy: test: No direct use of nose #46254

merged 3 commits into from May 24, 2022

Conversation

tserong
Copy link
Contributor

@tserong tserong commented May 13, 2022

backport tracker: https://tracker.ceph.com/issues/55615

backport of #45064
parent tracker: https://tracker.ceph.com/issues/54252

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@s-t-e-v-e-n-k @tserong
test/pybind/ceph_argparse: Switch to bare unittest
adfd441 
nose has been unmaintained for a long time, and to work on
removing it as a dependency, re-work test_ceph_argparse to use
bare unittest.

Signed-off-by: Steve Kowalik <steven@wedontsleep.org>
(cherry picked from commit 9f1c094)
@s-t-e-v-e-n-k @tserong
test/pybind/ceph_daemon: Switch to bare unittest
a3d434f 
nose has been unmaintained for a long time, and to work on
removing it as a dependency, re-work test_ceph_daemon to use
bare unittest.

Signed-off-by: Steve Kowalik <steven@wedontsleep.org>
(cherry picked from commit 34d8fc1)
@s-t-e-v-e-n-k @tserong
ceph.spec.in,debian/control: Remove nose
3fdbd08 
With the direct calls of nose methods removed, we no longer need to
BuildRequire it.

Fixes: https://tracker.ceph.com/issues/54252
Signed-off-by: Steve Kowalik <steven@wedontsleep.org>
(cherry picked from commit 47fba6f)
@tserong tserong added this to the quincy milestone May 13, 2022
@tserong tserong added the backport: no-conflicts Backport without conflicts label May 13, 2022
@tserong tserong requested review from tchaikov and cbodley and removed request for tchaikov May 13, 2022 04:14
@tserong tserong marked this pull request as draft May 13, 2022 04:17
@tserong tserong marked this pull request as ready for review May 13, 2022 04:30
@tserong
Copy link
Contributor Author

tserong commented May 17, 2022

jenkins test api

@tserong
Copy link
Contributor Author

tserong commented May 17, 2022

jenkins test windows

@ljflores
Copy link
Contributor

http://pulpito.front.sepia.ceph.com/yuriw-2022-05-19_18:50:25-rados-wip-yuri4-testing-2022-05-19-0831-quincy-distro-default-smithi/

Failures, unrelated:
1. https://tracker.ceph.com/issues/52321
2. https://tracker.ceph.com/issues/52657
3. https://tracker.ceph.com/issues/51076

Details:
1. qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Ceph - Orchestrator
2. MOSDPGLog::encode_payload(uint64_t): Assertion `HAVE_FEATURE(features, SERVER_NAUTILUS)' - Ceph - RADOS
3. "wait_for_recovery: failed before timeout expired" during thrashosd test with EC backend. - Ceph - RADOS

yuriw
yuriw approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@yuriw yuriw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Casey Bodley cbodley@redhat.com

@yuriw yuriw merged commit e2dc8ba into ceph:quincy May 24, 2022
@tserong tserong deleted the wip-55615-quincy branch May 26, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriw yuriw yuriw approved these changes

@cbodley cbodley Awaiting requested review from cbodley

@tchaikov tchaikov Awaiting requested review from tchaikov

Assignees
No one assigned
Labels
backport: no-conflicts Backport without conflicts build/ops needs-qa tests wip-yuri4-testing
Projects
None yet
Milestone
quincy
5 participants
@tserong @ljflores @yuriw @cbodley @s-t-e-v-e-n-k