New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: use a new disk as journal disk,ceph-disk prepare fail #4630

Merged
1 commit merged into from Jul 21, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented May 9, 2015

ceph-disk: more robust parted output parser
In some cases, depending on the implementation or the operating system,

   parted --machine -- /dev/sdh print

may contain empty lines. The current parsing code is fragile and highly
depends on output details. Replace it with code that basically does the
same sanity checks (output not empty, existence of units, existence of
the dev entry) but handles the entire output instead of checking line by
line.

http://tracker.ceph.com/issues/10983 Fixes: #10983

Signed-off-by: Loic Dachary <ldachary@redhat.com>
(cherry picked from commit f5acf6b)

@ghost ghost added bug fix core labels May 9, 2015

@ghost ghost self-assigned this May 9, 2015

@ghost ghost added this to the firefly milestone May 9, 2015

@ghost ghost assigned smithfarm and unassigned ghost Jun 2, 2015

@ghost ghost changed the title from use a new disk as journal disk,ceph-disk prepare fail to tools: use a new disk as journal disk,ceph-disk prepare fail Jul 21, 2015

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

this part of the ceph-disk code is used by all tests when preparing new disks attached to each machine running an OSD. http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi is all green, therefore this backport works as it should.

ghost pushed a commit that referenced this pull request Jul 21, 2015

Loic Dachary
Merge pull request #4630 from SUSE/wip-10983-firefly
tools: use a new disk as journal disk,ceph-disk prepare fail

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 4c37d3d into ceph:firefly Jul 21, 2015

@smithfarm smithfarm deleted the SUSE:wip-10983-firefly branch Jul 21, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment