New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Client admin socket leaks file descriptors #4633

Merged
merged 1 commit into from Jul 17, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented May 9, 2015

common/admin_socket: close socket descriptor in destructor
Long-running processes that do not reuse a single client connection will
see accumulating file descriptors as a result of not closing the
listening socket.  In this case, eventually the system will reach
file-max and subsequent connections will fail.

Fixes: #11535

Signed-off-by: Jon Bernard <jbernard@tuxion.com>
(cherry picked from commit 88fabb1)

@ghost ghost added bug fix core labels May 10, 2015

@ghost ghost added this to the firefly milestone May 10, 2015

@ghost ghost self-assigned this May 10, 2015

@ghost ghost added common and removed core labels May 10, 2015

@ghost ghost assigned smithfarm and unassigned ghost Jun 2, 2015

jdurgin added a commit that referenced this pull request Jul 17, 2015

Merge pull request #4633 from SUSE/wip-11535-firefly
Client admin socket leaks file descriptors

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

@jdurgin jdurgin merged commit 82e8359 into ceph:firefly Jul 17, 2015

@jdurgin

This comment has been minimized.

Member

jdurgin commented Jul 17, 2015

merged now since more folks are hitting this, its been in hammer and master for a while, and the admin socket code has only trivially changed since firefly.

@smithfarm smithfarm deleted the SUSE:wip-11535-firefly branch Jul 18, 2015

@ghost ghost changed the title from Client admin socket leaks file descriptors to common: Client admin socket leaks file descriptors Jul 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment