New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mds: wait unlink to finish to avoid conflict when creating same dentries #46331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few nits
jenkins test make check |
@lxbsz Is this ready for another round of review? |
Yeah, I have already fixed the issues as the comments mentioned. |
@lxbsz I'm seeing fsstresss job failures in teuthology - https://pulpito.ceph.com/vshankar-2022-08-10_04:06:00-fs-wip-vshankar-testing-20220805-190751-testing-default-smithi/6965167/ This is the only MDS related PR with significant changes in the branch. Could you check if the above failure (stalled job) is related to this change? |
Another instance - https://pulpito.ceph.com/vshankar-2022-08-10_04:06:00-fs-wip-vshankar-testing-20220805-190751-testing-default-smithi/6965181/ The create call seems to be blocked for ~3hrs
|
Sure, will check it. |
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Sure, I will run some of the teuthology tests those failed in your last run. But I am still hitting the |
Running this through fs suite: https://pulpito.ceph.com/vshankar-2022-09-05_05:44:13-fs-wip-vshankar-testing-20220901-100101-testing-default-smithi/ |
@lxbsz Could you please take a look at ffsb failure - https://pulpito.ceph.com/vshankar-2022-09-13_09:03:58-fs-wip-vshankar-testing-20220909-120801-testing-default-smithi/7030431/ Excerpt from the log:
The test times out and no activity is seen post |
@vshankar I think it should be caused by another PR #40787.
Not this one. |
I commented on that PR -- there are timeouts seen in other tests too..
|
@rishabh-d-dave Please include this in your next run. |
jenkins test make check arm64 |
jenkins test windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is ready for merge. Waiting for the CI jobs to finish first. |
Error look irrelevant - https://jenkins.ceph.com/job/ceph-pull-requests-arm64/33426/ |
jenkins test make check arm64 |
This test is optional , so we can just ignore this IMO. |
Since the QA testing was fine, merging this PR now. |
If the previous unlink request has been delayed due to some reasons,
and the new creating for the same dentry may fail or new open will
succeeds but new contents wrote to it will be lost.
The kernel client will make sure before the unlink getting the first
reply it won't send the followed create requests for the same dentry.
Here we need to make sure that before the first reply has been sent
out the dentry must be marked as unlinking.
Fixes: https://tracker.ceph.com/issues/55332
Signed-off-by: Xiubo Li xiubli@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows