Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: src/ceph-disk : disk zap sgdisk invocation #4636

Merged
1 commit merged into from Jul 21, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

commented May 10, 2015

Fix "disk zap" sgdisk invocation
Fixes #11143

If the metadata on the disk is truly invalid, sgdisk would fail to zero
it in one go, because --mbrtogpt apparently tried to operate on the
metadata it read before executing --zap-all.

Splitting this up into two separate invocations to first zap everything
and then clear it properly fixes this issue.

Based on patch by Lars Marowsky-Bree <lmb@suse.com> in ceph-deploy.
Created by Vincent Untz <vuntz@suse.com>

Signed-off-by: Owen Synge <osynge@suse.com>
Signed-off-by: Thorsten Behrens <tbehrens@suse.com>
(cherry picked from commit fdd7f8d)

@ghost ghost added core bug fix labels May 10, 2015

@ghost ghost added this to the firefly milestone May 10, 2015

@ghost ghost self-assigned this May 10, 2015

@ghost ghost assigned smithfarm and unassigned ghost Jun 2, 2015

@ghost

This comment has been minimized.

Copy link

commented Jul 8, 2015

@smithfarm #4788 conflicts with #4635 #4636 #4597, could you make it so they play nice together ?

@ghost ghost changed the title src/ceph-disk : disk zap sgdisk invocation tools: src/ceph-disk : disk zap sgdisk invocation Jul 21, 2015

@ghost

This comment has been minimized.

Copy link

commented Jul 21, 2015

This test just splits the zap command of ceph-disk in two. It is extensively used by the rados suite that passed successfully at http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi and this is proof enough that it did not introduce a regression.

ghost pushed a commit that referenced this pull request Jul 21, 2015

Loic Dachary
Merge pull request #4636 from SUSE/wip-11143-firefly
tools:  src/ceph-disk : disk zap sgdisk invocation

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit bde35c1 into ceph:firefly Jul 21, 2015

@smithfarm smithfarm deleted the SUSE:wip-11143-firefly branch Jul 21, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.