New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: Objectcacher setting max object counts too low #4639

Merged
merged 1 commit into from Jul 24, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented May 10, 2015

librbd: updated cache max objects calculation
The previous calculation was based upon the image's object size.
Since the cache stores smaller bufferheads, the object size is not
a good indicator of cache usage and was resulting in objects being
evicted from the cache too often.  Instead, base the max number of
objects on the memory load required to store the extra metadata
for the objects.

Fixes: #7385
Backport: firefly, hammer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 0b37894)

Conflicts:
	src/librbd/ImageCtx.cc
        because firefly has cct->_conf->rbd_cache_size
        instead of cache_size

@ghost ghost added bug fix rbd labels May 10, 2015

@ghost ghost added this to the firefly milestone May 10, 2015

@ghost ghost self-assigned this May 10, 2015

@ghost ghost assigned smithfarm and unassigned ghost Jun 2, 2015

@ghost ghost changed the title from Objectcacher setting max object counts too low to librbd: Objectcacher setting max object counts too low Jul 21, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 24, 2015

@dachary This has passed rbd suite as detailed in http://tracker.ceph.com/issues/11644

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 24, 2015

@jdurgin: This commit has passed integration tests (see the previous comment by @dachary) -- is it OK to merge? I'm asking you because you merged the master commit that this is a backport of: #4434

jdurgin added a commit that referenced this pull request Jul 24, 2015

Merge pull request #4639 from SUSE/wip-7385-firefly
librbd: Objectcacher setting max object counts too low

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

@jdurgin jdurgin merged commit b9f45fe into ceph:firefly Jul 24, 2015

@smithfarm smithfarm deleted the SUSE:wip-7385-firefly branch Jul 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment