Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephadm: fix osd adoption with custom cluster name #46481

Merged
merged 1 commit into from Jun 2, 2022

Conversation

guits
Copy link
Contributor

@guits guits commented Jun 1, 2022

When adopting Ceph OSD containers from a Ceph cluster with a custom name, it fails
because the name isn't propagated in unit.run.
The idea here is to change the lvm metadata and enforce 'ceph.cluster_name=ceph'
given that cephadm doesn't support custom names anyway.

Fixes: https://tracker.ceph.com/issues/55654

Signed-off-by: Adam King adking@redhat.com
Co-authored-by: Guillaume Abrioux gabrioux@redhat.com

@guits guits requested a review from a team as a code owner June 1, 2022 11:33
@guits guits force-pushed the cephadm-custom-names-osd-adoption branch 2 times, most recently from b1fcae2 to ccf3cab Compare June 1, 2022 12:13
src/cephadm/cephadm Outdated Show resolved Hide resolved
src/cephadm/cephadm Outdated Show resolved Hide resolved
src/cephadm/cephadm Outdated Show resolved Hide resolved
@guits guits force-pushed the cephadm-custom-names-osd-adoption branch 2 times, most recently from ddbeffe to 502e882 Compare June 1, 2022 12:31
When adopting Ceph OSD containers from a Ceph cluster with a custom name, it fails
because the name isn't propagated in unit.run.
The idea here is to change the lvm metadata and enforce 'ceph.cluster_name=ceph'
given that cephadm doesn't support custom names anyway.

Fixes: https://tracker.ceph.com/issues/55654

Signed-off-by: Adam King <adking@redhat.com>
Co-authored-by: Guillaume Abrioux <gabrioux@redhat.com>
@guits guits force-pushed the cephadm-custom-names-osd-adoption branch from 502e882 to e720a65 Compare June 1, 2022 16:49
@adk3798
Copy link
Contributor

adk3798 commented Jun 2, 2022

https://pulpito.ceph.com/adking-2022-06-02_01:28:06-orch:cephadm-wip-adk-testing-2022-06-01-1756-distro-default-smithi/

1 infra/teuthology failure:

{'smithi039.front.sepia.ceph.com': {'_ansible_no_log': False, 'attempts': 24, 'changed': False, 'invocation': {'module_args': {'allow_unauthenticated': False, 'autoclean': False, 'autoremove': False, 'cache_valid_time': 0, 'deb': None, 'default_release': None, 'dpkg_options': 'force-confdef,force-confold', 'force': False, 'force_apt_get': False, 'install_recommends': None, 'only_upgrade': False, 'package': None, 'policy_rc_d': None, 'purge': False, 'state': 'present', 'update_cache': True, 'update_cache_retries': 5, 'update_cache_retry_max_delay': 12, 'upgrade': None}}, 'msg': 'Failed to update apt cache: unknown reason'}}

from before the test actually started.

@adk3798 adk3798 merged commit 45cd4f9 into ceph:main Jun 2, 2022
12 checks passed
@guits guits deleted the cephadm-custom-names-osd-adoption branch June 3, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants