pacific: mgr/cephadm: don't redeploy osds seen in raw list if cephadm knows them #46545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As is already done when checking the lvm list results and should also be done for checking raw list but is missing do ot a backporting mistake Tachnically a partial backport of ceph#44228 that was not included in ceph#44627 because raw osd support was not in pacific then Signed-off-by: Adam King <adking@redhat.com>
|
I have officially learned my lesson with backporting large things a long time after they initially get into the dev branch. Never again. Hopefully this is the last of the issues around the raw osd backport |
guits
approved these changes
Jun 7, 2022
|
@adk3798 why isn't this one backported to Quincy too? |
forget about that, I just figured it out. |
|
https://pulpito.ceph.com/adking-2022-06-08_14:40:24-orch:cephadm-wip-adk2-testing-2022-06-07-2105-pacific-distro-default-smithi/ Failures tracked by:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is already done when checking the lvm list
results and should also be done for checking raw
list but is missing do to a backporting mistake
Technically a partial backport of part of #44228 that
was not included in #44627 because raw osd support
was not in pacific then
Signed-off-by: Adam King adking@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows