Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: admin_socket: close socket descriptor in destructor #4657

Merged
1 commit merged into from Jul 10, 2015

Conversation

Projects
None yet
4 participants
@ktdreyer
Copy link
Member

commented May 12, 2015

common/admin_socket: close socket descriptor in destructor
Long-running processes that do not reuse a single client connection will
see accumulating file descriptors as a result of not closing the
listening socket.  In this case, eventually the system will reach
file-max and subsequent connections will fail.

Fixes: #11535

Signed-off-by: Jon Bernard <jbernard@tuxion.com>
(cherry picked from commit 88fabb1)

@ktdreyer ktdreyer added this to the hammer milestone May 12, 2015

@ghost ghost self-assigned this May 12, 2015

@ghost ghost changed the title common/admin_socket: close socket descriptor in destructor DNM: common/admin_socket: close socket descriptor in destructor May 12, 2015

@ghost

This comment has been minimized.

Copy link

commented May 12, 2015

@ktdreyer just to avoid interferences while QE is running tests on hammer.

@ktdreyer

This comment has been minimized.

Copy link
Member Author

commented May 12, 2015

Oh, ok. I just asked Josh to look and merge this since we're going to take this patch in RHCS downstream. I didn't realize we're in a freeze on the hammer branch at this time.

@ghost

This comment has been minimized.

Copy link

commented May 12, 2015

@ktdreyer there is no freeze really. I'm just trying to reduce interferences but it would not harm the process if it had been merged.

@ghost

This comment has been minimized.

Copy link

commented May 12, 2015

@ktdreyer you can take a look at http://tracker.ceph.com/issues/11492#Workflow to see at which point of the workflow we are. That should give you an idea of the possible impact of merging at any given point in time. The latest branch being worked on is always linked from http://tracker.ceph.com/projects/ceph-releases/wiki/HOWTO#Overview-of-the-backports-in-progress

@ghost ghost changed the title DNM: common/admin_socket: close socket descriptor in destructor common/admin_socket: close socket descriptor in destructor Jun 13, 2015

@ghost

This comment has been minimized.

Copy link

commented Jun 13, 2015

We're on the path to 0.94.3

@theanalyst

This comment has been minimized.

Copy link
Member

commented Jul 10, 2015

This has passed the first round of integration tests for hammer at http://tracker.ceph.com/issues/11990#rados @ktdreyer @dachary Do you think it is ready to merge

ghost pushed a commit that referenced this pull request Jul 10, 2015

Loic Dachary
Merge pull request #4657 from ceph/wip-hammer-11535-admin-socket
common/admin_socket: close socket descriptor in destructor

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 5088105 into hammer Jul 10, 2015

@ghost ghost changed the title common/admin_socket: close socket descriptor in destructor common: admin_socket: close socket descriptor in destructor Aug 4, 2015

@ktdreyer ktdreyer deleted the wip-hammer-11535-admin-socket branch Sep 15, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.