pacific: mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd #46691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cmd Before proceeding to handle "osd new" mon command as part of OSDMonitor::prepare_command_impl(), a check is made to verify if the authmon is writeable. Later on, prepare_command_osd_new() invokes KVMonitor::do_osd_new() to create pending dmcrypt keys and calls propose_pending(). The propose could fail (with an assertion failure) if there was a prior mon command that resulted in the kvmon invoking propose_pending(). In order to avoid such a situation, introduce a check to verify that kvmon is also writeable in OSDMonitor::prepare_command_impl(). If it is not writeable, the op is pushed into the wait_for_active context queue to be retried later. Fixes: https://tracker.ceph.com/issues/55773 Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com> (cherry picked from commit 9a0d42c)
|
jenkins test make check |
neha-ojha
approved these changes
Jun 15, 2022
|
Teuthology Test Result There were no related failures across the two teuthology runs. Unrelated Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/56059
backport of #46428
parent tracker: https://tracker.ceph.com/issues/55773
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh