mgr/dashboard: do not recommend throughput for ssd's only cluster #46889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizamial09
force-pushed
the
osd-followup-iops
branch
from
6e6745a
to
7ea8ac6
Compare
sunilangadi2
approved these changes
Jun 29, 2022
epuertat
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Quick and efficient as always, @nizamial09 ! If it works, it works... but I have a few concerns.
Comment on lines
370
to
378
| nvme_model = None | ||
| ssd_model = None | ||
| for inventory_host in orch.inventory.list(hosts=None, refresh=True): | ||
| for device in inventory_host.devices.devices: | ||
| if device.available and device.human_readable_type == 'ssd': | ||
| if '/dev/nvme' in device.path: | ||
| nvme_model = device.sys_api['model'] | ||
| else: | ||
| ssd_model = device.sys_api['model'] |
There was a problem hiding this comment.
This is still a hack... What it more than 1 model is used for SSDs or NVMes? Can't we pass a path pattern to match NMVe/SSD devs?
@adk3798 do you know if we can pass globs to the path of a device?
pereman2
reviewed
Jun 29, 2022
nizamial09
force-pushed
the
osd-followup-iops
branch
from
7ea8ac6
to
63d936c
Compare
This is just a bug fix where we recommend the throughput option even if there are only ssd's are present in the cluster. Fixes: https://tracker.ceph.com/issues/56413 Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
osd-followup-iops
branch
from
63d936c
to
0f6f79f
Compare
nizamial09
changed the title
|
@epuertat @pereman2 @sunilangadi2 I changed the approach to only fix the bug which is happening here and added the tests for it. please re-review this. |
epuertat
approved these changes
Jul 18, 2022
Comment on lines
+514
to
+515
| elif '/dev/nvme' in device.path: | ||
| nvmes += 1 |
This was referenced Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a bug fix where we recommend the throughput option even if
there are only ssd's are present in the cluster.
Fixes: https://tracker.ceph.com/issues/56413
Signed-off-by: Nizamudeen A nia@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows