Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: osd/SnapMapper: fix legacy key conversion in snapmapper class #47133

Merged
merged 1 commit into from Aug 18, 2022
Merged

quincy: osd/SnapMapper: fix legacy key conversion in snapmapper class #47133

merged 1 commit into from Aug 18, 2022

Conversation

Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Jul 17, 2022

backport tracker: https://tracker.ceph.com/issues/56578

backport of #46908
parent tracker: https://tracker.ceph.com/issues/56147

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh

@mlausch @Matan-B
osd/SnapMapper: fix pacific legacy key conversion and introduce test
9b5fbb8 
Octopus modified the SnapMapper key format from

  <LEGACY_MAPPING_PREFIX><snapid>_<shardid>_<hobject_t::to_str()>

to

  <MAPPING_PREFIX><pool>_<snapid>_<shardid>_<hobject_t::to_str()>

When this change was introduced, 94ebe0e also introduced a conversion
with a crucial bug which essentially destroyed legacy keys by mapping them
to

  <MAPPING_PREFIX><poolid>_<snapid>_

without the object-unique suffix.  This commit fixes this conversion going
forward, but a fix for existing clusters still needs to be developed.

Fixes: https://tracker.ceph.com/issues/56147
Signed-off-by: Manuel Lausch <manuel.lausch@1und1.de>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 66bea86)
@Matan-B Matan-B requested a review from a team as a code owner July 17, 2022 09:02
@Matan-B Matan-B added this to the quincy milestone Jul 17, 2022
@Matan-B Matan-B added the core label Jul 17, 2022
@github-actions github-actions bot added the tests label Jul 17, 2022
@Matan-B
Copy link
Contributor Author

Matan-B commented Jul 19, 2022

jenkins test api

@Matan-B
Copy link
Contributor Author

Matan-B commented Jul 19, 2022

jenkins test windows

@Matan-B
Copy link
Contributor Author

Matan-B commented Aug 18, 2022

Rados Approves

0 Related Failures.
9 Tracked unrelated Failures.
0 Newly Tracked Failures.
3 Tracked dead Jobs.

https://pulpito.ceph.com/yuriw-2022-08-15_17:54:08-rados-wip-yuri2-testing-2022-08-15-0848-quincy-distro-default-smithi/

Failures, unrelated:

  1. 6973678,6973835: https://tracker.ceph.com/issues/52321
  2. 6973682,6973889: https://tracker.ceph.com/issues/57165
  3. 6973757,6973915: https://tracker.ceph.com/issues/56951
  4. 6973763: https://tracker.ceph.com/issues/53422
  5. 6973866: https://tracker.ceph.com/issues/56391
  6. 6973901: https://tracker.ceph.com/issues/50536

Dead:
7. 6973760: https://tracker.ceph.com/issues/49888
8. 6973864: https://tracker.ceph.com/issues/56391
9. 6973876: https://tracker.ceph.com/issues/57092

Details:

  1. qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds

  2. expected valgrind issues and found none

  3. rook/smoke: Updating cephclusters/rook-ceph is forbidden

  4. tasks.cephfs.test_nfs.TestNFS.test_export_create_with_non_existing_fsname: AssertionError: NFS Ganesha cluster deployment failed

  5. Most likely releated to (8) "the output has been hidden due to the fact that 'no_log: true' was specified for this result"

  6. "Command failed (workunit test rados/test.sh)" - rados/test.sh times out.

  7. rados/singleton: radosbench.py: teuthology.exceptions.MaxWhileTries: reached maximum tries (3650) after waiting for 21900 seconds

  8. "the output has been hidden due to the fact that 'no_log: true' was specified for this result"

  9. teuthology reimage fails w/ ssh_keyscan reached maximum tries.

@yuriw yuriw merged commit a52acde into ceph:quincy Aug 18, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

Assignees
No one assigned
Labels
core needs-qa tests wip-yuri2-testing
Projects
None yet
Milestone
quincy
4 participants
@Matan-B @neha-ojha @yuriw @mlausch