Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: rgw: Guard against malformed bucket URLs #47191

Merged
merged 2 commits into from Aug 2, 2022
Merged

quincy: rgw: Guard against malformed bucket URLs #47191

merged 2 commits into from Aug 2, 2022

Conversation

adamemerson
Copy link
Contributor

@adamemerson adamemerson commented Jul 20, 2022 •
edited

Backport of fix for https://tracker.ceph.com/issues/55765 to Quincy.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@adamemerson
rgw: Fix rgw::sal::Bucket::empty static method signatures
e40ce4a 
`unique_ptr` overload should take by reference.

Both should be const.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit b1d3e6c)

Conflicts:
	src/rgw/rgw_sal.h
 - `unique_ptr` overload of empty

Fixes: https://tracker.ceph.com/issues/56585
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@adamemerson
rgw: Guard against malformed bucket URLs
f0da8c0 
Misplaced colons can result in radosgw thinking is has a bucket URL
but with no bucket name, leading to a crash later on.

Fixes: https://tracker.ceph.com/issues/55765
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
(cherry picked from commit 3ee9a3b)
Fixes: https://tracker.ceph.com/issues/56585
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@adamemerson adamemerson requested a review from cbodley July 20, 2022 17:19
@github-actions github-actions bot added the rgw label Jul 20, 2022
@github-actions github-actions bot added this to the quincy milestone Jul 20, 2022
@yuriw yuriw merged commit c738e0e into ceph:quincy Aug 2, 2022
14 of 15 checks passed
@adamemerson adamemerson deleted the wip-56585-quincy branch September 15, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees
No one assigned
Labels
backport quincy needs-qa rgw wip-yuri5-testing
Projects
None yet
Milestone
quincy
3 participants
@adamemerson @cbodley @yuriw