Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: add required validation for frontend and monitor port #47260

Merged
merged 1 commit into from Jul 29, 2022
Merged

mgr/dashboard: add required validation for frontend and monitor port #47260

merged 1 commit into from Jul 29, 2022

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Jul 25, 2022 •
edited

Fixes: https://tracker.ceph.com/issues/56688
Signed-off-by: Avan Thakkar athakkar@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@avanthakkar avanthakkar requested a review from a team as a code owner July 25, 2022 10:37
@avanthakkar avanthakkar added this to In progress in Dashboard via automation Jul 25, 2022
@avanthakkar avanthakkar requested review from aaSharma14 and bryanmontalvan and removed request for a team July 25, 2022 10:37
@avanthakkar avanthakkar added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Jul 25, 2022
Dashboard automation moved this from In progress to Reviewer approved Jul 25, 2022
@avanthakkar
Copy link
Contributor Author

jenkins test windows

1 similar comment
@aaSharma14
Copy link
Contributor

jenkins test windows

@nizamial09
Copy link
Member

jenkins test windows

@nizamial09 nizamial09 merged commit 1e46a22 into ceph:main Jul 29, 2022
15 of 16 checks passed
@nizamial09 nizamial09 deleted the fix-frontend-monitor-port-fields branch July 29, 2022 07:07
Dashboard automation moved this from Reviewer approved to Done Jul 29, 2022
This was referenced Jul 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@nizamial09 nizamial09 nizamial09 approved these changes

@bryanmontalvan bryanmontalvan Awaiting requested review from bryanmontalvan bryanmontalvan is a code owner automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
dashboard pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
3 participants
@avanthakkar @aaSharma14 @nizamial09