Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: host list tables doesn't show all services deployed #47263

Merged
merged 2 commits into from Aug 4, 2022
Merged

mgr/dashboard: host list tables doesn't show all services deployed #47263

merged 2 commits into from Aug 4, 2022

Conversation

avanthakkar
Copy link
Contributor

@avanthakkar avanthakkar commented Jul 25, 2022 •
edited

Cluster->Host Service instances was displaying only the ceph services, but with these changes it'll display instances
of cephadm services as well.

Before:
Screenshot from 2022-07-25 19-44-39

After:
Screenshot from 2022-07-25 18-27-04

Fixes: https://tracker.ceph.com/issues/53210
Signed-off-by: Avan Thakkar athakkar@redhat.com

Service instances was displaying only the ceph services, but with these changes it'll display instances
of cephadm services as well.

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@avanthakkar avanthakkar added this to In progress in Dashboard via automation Jul 25, 2022
@avanthakkar avanthakkar changed the title mgr/dashboard: cluster > hosts: host list tables doesn't show all ser… mgr/dashboard: host list tables doesn't show all services deployed Jul 25, 2022
@avanthakkar avanthakkar force-pushed the fix-host-service-instances branch 2 times, most recently from c3b2822 to 718406b Compare July 25, 2022 15:02
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

1 similar comment
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member

nizamial09 commented Aug 1, 2022 •
edited

shaman builds success ✔️
teuthology failed ❌

@avanthakkar
mgr/dashboard: cluster > hosts: host list tables doesn't show all ser…
4d50da7 
…vices deployed

Fixes: https://tracker.ceph.com/issues/53210
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Service instances was displaying only the ceph services, but with these changes it'll display instances
of cephadm services as well.
@avanthakkar avanthakkar marked this pull request as ready for review August 1, 2022 17:12
@avanthakkar avanthakkar requested a review from a team as a code owner August 1, 2022 17:12
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@avanthakkar
Copy link
Contributor Author

jenkins test make check

@avanthakkar
mgr/dashboard: add cephadm e2e tests for checking count for services …
25b03d8 
…instances

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

Dashboard automation moved this from In progress to Reviewer approved Aug 3, 2022
sunilangadi2
sunilangadi2 approved these changes Aug 3, 2022
View reviewed changes
Copy link

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@avanthakkar
Copy link
Contributor Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member

newly added test is passing and cephadm e2e failure was because of the loki/grafana issue
✓ should show the exact count of daemons

@nizamial09 nizamial09 merged commit 4697911 into ceph:main Aug 4, 2022
12 of 13 checks passed
Dashboard automation moved this from Reviewer approved to Done Aug 4, 2022
@nizamial09 nizamial09 deleted the fix-host-service-instances branch August 4, 2022 07:28
This was referenced Aug 4, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilangadi2 sunilangadi2 sunilangadi2 approved these changes

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@nizamial09 nizamial09 Awaiting requested review from nizamial09

Assignees
No one assigned
Labels
dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
4 participants
@avanthakkar @nizamial09 @sunilangadi2 @aaSharma14