Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: rgw: better tenant id from the uri on anonymous access #47342

Merged
merged 1 commit into from Aug 5, 2022
Merged

quincy: rgw: better tenant id from the uri on anonymous access #47342

merged 1 commit into from Aug 5, 2022

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Jul 28, 2022

backport tracker: https://tracker.ceph.com/issues/56955

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@mdw-at-linuxbox @cbodley
rgw: better tenant id from the uri on anonymous access
71a35a7 
When anonymous tries access public bucket, it gets 404,
because rgw doesn't check tenant correctly.

A previous fix for this broke legacy implicit tenants,
because it didn't check for anonymous access.  This version
restricts its behavior to the anonymous user.

Fixes: https://tracker.ceph.com/issues/48001 https://tracker.ceph.com/issues/48382

Original fix by
Author: Rafał Wądołowski <rafal@rafal.net.pl>
Signed-off-by: Rafał Wądołowski <rwadolowski@cloudferro.com>

This fix
Signed-off-by: Marcus Watts <mwatts@redhat.com>
(cherry picked from commit b5880ca)
@cbodley cbodley added rgw needs-qa backport: no-conflicts Backport without conflicts labels Jul 28, 2022
@cbodley cbodley added this to the quincy milestone Jul 28, 2022
@cbodley cbodley mentioned this pull request Jul 28, 2022
Merged
@ljflores
Copy link
Contributor

ljflores commented Aug 4, 2022

Rados suite results: https://pulpito.ceph.com/?branch=wip-yuri8-testing-2022-08-03-1028-quincy

Failures, unrelated:
1. https://tracker.ceph.com/issues/55809
2. https://tracker.ceph.com/issues/52321
3. https://tracker.ceph.com/issues/55854
4. https://tracker.ceph.com/issues/55897
5. https://tracker.ceph.com/issues/56951

Details:
1. "Leak_IndirectlyLost" valgrind report on mon.c - Ceph - RADOS
2. qa/tasks/rook times out: 'check osd count' reached maximum tries (90) after waiting for 900 seconds - Ceph - Rook
3. Datetime AssertionError in test_health_history (tasks.mgr.test_insights.TestInsights) - Ceph - Mgr
4. test_nfs: update of export's access type should not trigger NFS service restart - Ceph - CephFS
5. rook/smoke: Updating cephclusters/rook-ceph is forbidden - Ceph - Orchestrator

yuriw
yuriw approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@yuriw yuriw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Casey Bodley cbodley@redhat.com

@yuriw yuriw merged commit ccf2c7a into ceph:quincy Aug 5, 2022
11 checks passed
@cbodley cbodley deleted the wip-56955 branch August 5, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriw yuriw yuriw approved these changes

@dang dang Awaiting requested review from dang

@mattbenjamin mattbenjamin Awaiting requested review from mattbenjamin

@mdw-at-linuxbox mdw-at-linuxbox Awaiting requested review from mdw-at-linuxbox

Assignees
No one assigned
Labels
backport: no-conflicts Backport without conflicts needs-qa rgw wip-yuri8-testing
Projects
None yet
Milestone
quincy
4 participants
@cbodley @ljflores @yuriw @mdw-at-linuxbox