quincy: osd: Handle oncommits and wait for future work items from mClock queue #47490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a worker thread with the smallest thread index waits for future work items from the mClock queue, oncommit callbacks are called. But after the callback, the thread has to continue waiting instead of returning back to the ShardedThreadPool::shardedthreadpool_worker() loop. Returning results in the threads with the smallest index across all shards to busy loop causing very high CPU utilization. The fix involves reacquiring the shard_lock and waiting on sdata_cond until notified or until time period lapses. After this, the smallest thread index repopulates the oncommit queue from the context_queue if there were any additions. Fixes: https://tracker.ceph.com/issues/56530 Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com> (cherry picked from commit 180a5a7)
|
jenkins test make check |
neha-ojha
approved these changes
Aug 8, 2022
|
Teuthology Test Result Summary Unrelated Failures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/57052
backport of #47216
parent tracker: https://tracker.ceph.com/issues/56530
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh