mgr/dashboard: fix nfs exports form issues with squash field #47571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizamial09
requested review from
nSedrickm and
pereman2
and removed request for
a team
nizamial09
changed the title
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
|
jenkins test make check |
|
jenkins test make check |
|
jenkins test dashboard |
nizamial09
force-pushed
the
nfs-form-squash-norequired
branch
from
20a571e
to
8d9f05e
Compare
|
jenkins retest this please |
1. Squash is not a mandatory field. 2. If the export is created from backend, then squash can have many different names for each types of squash. for eg. ``` ['root', 'root_squash', 'rootsquash', 'rootid', 'root_id_squash', 'rootidsquash', 'all', 'all_squash', 'allsquash', 'all_anomnymous', 'allanonymous', 'no_root_squash', 'none', 'noidsquash'] ``` so we need a proper matching in the ui too otherwise the edit field will not have any value for the squash field. 3. Removed unncessary dropdown helper if there are values for the squash and access types. Fixes: https://tracker.ceph.com/issues/57114 Signed-off-by: Nizamudeen A <nia@redhat.com>
This actually broke the doc service when the developer environment is of main branch Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
nfs-form-squash-norequired
branch
from
8d9f05e
to
be5ab2f
Compare
|
jenkins test make check |
|
jenkins test api |
|
jenkins test dashboard |
aaSharma14
approved these changes
Aug 30, 2022
|
jenkins test dashboard cephadm |
|
jenkins test make check |
|
jenkins test dashboard |
|
jenkins test make check |
|
jenkins test dashboard |
|
jenkins test make check |
This was referenced Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
different names for each types of squash. for eg.
so we need a proper matching in the ui too otherwise the edit field will
not have any value for the squash field.
and access types.
Fixes: https://tracker.ceph.com/issues/57114
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows