mgr/dashboard: osd form preselect db/wal device filters #47574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nizamial09
requested review from
nSedrickm and
Pegonzal
and removed request for
a team
...ard/frontend/src/app/ceph/cluster/inventory/inventory-devices/inventory-devices.component.ts
Show resolved
Hide resolved
|
jenkins test api |
|
jenkins test dashboard |
|
jenkins test make check |
|
make check failure seems related to the PR |
|
jenkins test api |
|
jenkins test dashboard |
If the hostname is selected for the primary devices, then we can preselect the hostname filter for the db/wal devices because osds will be deployed only on the hostname of the primary device. If preselected it'll be clear that only this devices will be used to deploy. Addition to this, usually ssd devices are used for db/wal devices. So I am preselecting these too in the filters. Fixes: https://tracker.ceph.com/issues/57118 Signed-off-by: Nizamudeen A <nia@redhat.com>
nizamial09
force-pushed
the
osd-form-hostname-filter
branch
from
1cd640d
to
5f8eff3
Compare
|
cephadm e2e failure tracked here: https://tracker.ceph.com/issues/57511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the hostname is selected for the primary devices, then we can
preselect the hostname filter for the db/wal devices because osds will
be deployed only on the hostname of the primary device. If preselected
it'll be clear that only this devices will be used to deploy.
Addition to this, usually ssd devices are used for db/wal devices. So I
am preselecting these too in the filters.
scrnli_12_08_2022_21-00-16.mp4
Fixes: https://tracker.ceph.com/issues/57118
Signed-off-by: Nizamudeen A nia@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows