quincy: osd/scrub: Reintroduce scrub starts message

[pdvian]

backport tracker: https://tracker.ceph.com/issues/56134

---

backport of #46438
parent tracker: https://tracker.ceph.com/issues/55798

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

[pdvian]

@ronen-fr Kindly review this quincy backport PR. I have not included formatter<pg_t> changes in this PR as <pg_t> formatter is not part of quincy release yet :

template <>
struct fmt::formatter<pg_t> {
  constexpr auto parse(format_parse_context& ctx) { return ctx.begin(); }

  template <typename FormatContext>
  auto format(const pg_t& pg, FormatContext& ctx)
  {
    return fmt::format_to(ctx.out(), "{}.{:x}", pg.pool(), pg.m_seed);
  }
};

[pdvian]

@ronen-fr Kindly review this quincy backport PR. I have not included formatter<pg_t> changes in this PR as <pg_t> formatter is not part of quincy release yet :

template <>
struct fmt::formatter<pg_t> {
  constexpr auto parse(format_parse_context& ctx) { return ctx.begin(); }

  template <typename FormatContext>
  auto format(const pg_t& pg, FormatContext& ctx)
  {
    return fmt::format_to(ctx.out(), "{}.{:x}", pg.pool(), pg.m_seed);
  }
};

@ronen-fr I have added fmt::formatter<pg_t> changes to this PR. It needs to be included in quincy as we are using pg_t formatter in set_scrub_begin_time. Kindly review this PR.

[ronen-fr]

@pdvian : LGTM. Not sure if the 'make check' failure (which is unrelated) means this should be rebased.

[ronen-fr]

jenkins retest this please

[pdvian]

jenkins retest this please

[ljflores]

Rados suite review: https://pulpito.ceph.com/?branch=wip-yuri-testing-2022-08-23-1120-quincy

Failures, unrelated:
1. https://tracker.ceph.com/issues/57303 -- Pending Quincy backport
2. https://tracker.ceph.com/issues/57269
3. https://tracker.ceph.com/issues/57165 -- Fix under review
4. https://tracker.ceph.com/issues/57270
5. https://tracker.ceph.com/issues/57311
6. https://tracker.ceph.com/issues/49287

Details:
1. rados/cephadm: Failed to fetch package version from https://shaman.ceph.com/api/search/?status=ready&project=ceph&flavor=default&distros=ubuntu%2F22.04%2Fx86_64&sha1=b34ca7d1c2becd6090874ccda56ef4cd8dc64bf7 - Ceph - Orchestrator
2. rook: unable to read URL "https://docs.projectcalico.org/manifests/tigera-operator.yaml" - Ceph - Orchestrator
3. expected valgrind issues and found none - Ceph - RADOS
4. cephadm: RuntimeError: Failed command: apt-get update: E: The repository 'https://download.ceph.com/debian-octopus jammy Release' does not have a Release file. - Ceph - Orchestrator
5. rook: ensure CRDs are installed first - Ceph - Orchestrator
6. podman: setting cgroup config for procHooks process caused: Unit libpod-$hash.scope not found - Ceph - Orchestrator

[ljflores]

jenkins test make check

[yuriw]

jenkins test make check

[yuriw]

jenkins test make check

[yuriw]

jenkins test make check

[yuriw]

@pdvian
This PR failed make check:
The following tests FAILED:
31 - run-rbd-unit-tests-1.sh (Timeout)
273 - run-tox-alerts-lint (Failed)

@ilya FYI

https://jenkins.ceph.com/job/ceph-pull-requests/102848/

[yuriw]

jenkins test make check

[yuriw]

jenkins test make check

[yuriw]

@pdvian can't merge it :(

[rzarzynski]

jenkins test make check