Ceph-mixin: Fix CephNodeNetworkPacket alerts #47707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosc0
requested review from
aaSharma14 and
nizamial09
and removed request for
a team
bosc0
changed the title
MrFreezeex
requested changes
Aug 22, 2022
bosc0
force-pushed
the
fix_alert
branch
2 times, most recently
from
93e1197
to
b712484
Compare
MrFreezeex
approved these changes
Aug 23, 2022
MrFreezeex
reviewed
Aug 23, 2022
bosc0
force-pushed
the
fix_alert
branch
5 times, most recently
from
6d6abcf
to
03a1981
Compare
Signed-off-by: Aswin Toni <aswin.toni@cern.ch>
|
jenkins test make check |
epuertat
approved these changes
Aug 24, 2022
| ) / ( | ||
| rate(node_network_receive_packets_total{device!="lo"}[1m]) + | ||
| rate(node_network_transmit_packets_total{device!="lo"}[1m]) | ||
| ) >= 0.0050000000000000001 and ( |
There was a problem hiding this comment.
floats, you have to love them! 🙈
aaSharma14
approved these changes
Aug 30, 2022
|
jenkins test dashboard cephadm |
|
jenkins test dashboard |
|
jenkins test windows |
|
I'm merging this as I want to be able to backport the recent changes of ceph-mixin up to pacific (and there are a couple not tracked in the trackers oups). I'm leaving CERN rather soon and I probably won't have access to a dev environment for a few weeks to do that but if @mmgaggle or someone else has a follow up suggestion/PR would be happy to help. |
This was referenced Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
CephNodeNetworkPacketDropsandCephNodeNetworkPacketErrorsalert queries count the amount of packet drops/errors per minute instead of per second as mentioned in the description. This commit fixes that and makes the threshold values customizable with slightly higher defaultsContribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows