New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: ceph-disk: support NVMe device partitions #4771

Merged
1 commit merged into from Jul 21, 2015

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented May 26, 2015

ceph-disk: support NVMe device partitions
Linux nvme kernel module v0.9 enumerate devices as following:

/dev/nvme0 - characted revice
/dev/nvme0n1 - whole block device
/dev/nvme0n1p1 - first partition
/dev/nvme0n1p2 - second partition

http://tracker.ceph.com/issues/11612 Fixes: #11612

Signed-off-by: Ilja Slepnev <islepnev@gmail.com>
(cherry picked from commit 9b62cf2)

Conflicts:
	src/ceph-disk

@smithfarm smithfarm added this to the firefly milestone May 26, 2015

@smithfarm smithfarm self-assigned this May 26, 2015

@smithfarm smithfarm changed the title from ceph-disk: get_partition_type fails on /dev/cciss... to ceph-disk: support NVMe device partitions Jun 6, 2015

@ghost ghost changed the title from ceph-disk: support NVMe device partitions to tools: ceph-disk: support NVMe device partitions Jul 21, 2015

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi passed and uses ceph-disk for each disk attached to a machine running an osd. This commit is simple and the only risk is to introduce a trivial regression that would fail parsing that previously worked.

ghost pushed a commit that referenced this pull request Jul 21, 2015

Loic Dachary
Merge pull request #4771 from SUSE/wip-11759-firefly
tools: ceph-disk: support NVMe device partitions

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit 13946e9 into ceph:firefly Jul 21, 2015

@smithfarm smithfarm deleted the SUSE:wip-11759-firefly branch Jul 21, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment