Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: add replication status header to s3 GetObj response #47743

Merged
merged 1 commit into from Jan 22, 2023

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Aug 22, 2022

implements the easy part of amazon's x-amz-replication-status feature: https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication-status.html#replication-status-overview

also adds rgw header x-rgw-replicated-from for each zone in the replication trace

Fixes: https://tracker.ceph.com/issues/58565

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cbodley cbodley marked this pull request as ready for review September 29, 2022 20:59
implements the easy part of amazon's x-amz-replication-status feature:

https://docs.aws.amazon.com/AmazonS3/latest/userguide/replication-status.html#replication-status-overview

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley cbodley changed the title rgw: add replication status headers to s3 GetObj response rgw: add replication status header to s3 GetObj response Jan 17, 2023
@cbodley
Copy link
Contributor Author

cbodley commented Jan 17, 2023

also adds rgw header x-rgw-replicated-from for each zone in the replication trace

this part wasn't working, so i split it out to #49767

@mattbenjamin
Copy link
Contributor

woot

@ivancich ivancich added the wip-eric-testing-1 for ivancich testing label Jan 19, 2023
@ivancich
Copy link
Member

jenkins test make check

@ivancich ivancich merged commit 4130679 into ceph:main Jan 22, 2023
12 of 13 checks passed
@mattbenjamin
Copy link
Contributor

@ivancich thank you!

@ivancich
Copy link
Member

@cbodley and @mattbenjamin : merged; I'm thinking this should have backports....

@ivancich ivancich removed wip-eric-testing-1 for ivancich testing needs-qa labels Jan 22, 2023
@mattbenjamin
Copy link
Contributor

It would be helpful in Quincy, I think

@ivancich
Copy link
Member

Thanks, @mattbenjamin. I've added a tracker for this PR, listed quincy as a desired backport, and set status to Pending Backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants