New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: fix unmanaged service creation #47784
Conversation
d3fd033
to
680bcfa
Compare
|
@avanthakkar pointed it out to me that apart from the ingress services like iscsi and snmp-gateway faces this issue. so adding the fixes for them too. |
14a6ae2
to
4105a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
the following snipped is the error from backend
```
File "/lib/python3.6/site-packages/ceph/deployment/service_spec.py", line 698, in _from_json_impl
_cls.validate()
File "/lib/python3.6/site-packages/ceph/deployment/service_spec.py", line 1058, in validate
'Cannot add ingress: No frontend_port specified')
ceph.deployment.hostspec.SpecValidationError: Cannot add ingress: No frontend_port specified
```
It looks like even if we set unmanaged flag, we need to input the
backend_service, frontend_port, monitor_port and virtual_ip, because there is a
validation going for that in the backend.
https://github.com/ceph/ceph/blob/main/src/python-common/ceph/deployment/service_spec.py#L1050
Fixes: https://tracker.ceph.com/issues/57284
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
4105a31
to
a35651e
Compare
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
1 similar comment
|
jenkins test dashboard cephadm |
|
jenkins test dashboard |
|
jenkins test windows |
|
the applitools is failing after several retries and accepting https://jenkins.ceph.com/job/ceph-dashboard-pull-requests/11648/ |
Fixes
the following snipped is the error from backend
It looks like even if we set unmanaged flag, we need to input the
backend_service, frontend_port, monitor_port and virtual_ip, because there is a
validation going for that in the backend.
https://github.com/ceph/ceph/blob/main/src/python-common/ceph/deployment/service_spec.py#L1050
AFTER


INGRESS
ISCSI

SNMP-v3

SNMP-v2c

Fixes: https://tracker.ceph.com/issues/57284
Signed-off-by: Nizamudeen A nia@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows