Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: fix unmanaged service creation #47784

Merged
merged 3 commits into from Sep 9, 2022

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Aug 24, 2022

Fixes

  1. Ingress unmanaged service creation
  2. iSCSI unmanaged service creation
  3. snmp unmanaged service creation

the following snipped is the error from backend

 File "/lib/python3.6/site-packages/ceph/deployment/service_spec.py", line 698, in _from_json_impl
                                                  _cls.validate()
                                                File "/lib/python3.6/site-packages/ceph/deployment/service_spec.py", line 1058, in validate
                                                  'Cannot add ingress: No frontend_port specified')
                                              ceph.deployment.hostspec.SpecValidationError: Cannot add ingress: No frontend_port specified

It looks like even if we set unmanaged flag, we need to input the
backend_service, frontend_port, monitor_port and virtual_ip, because there is a
validation going for that in the backend.

https://github.com/ceph/ceph/blob/main/src/python-common/ceph/deployment/service_spec.py#L1050

AFTER
INGRESS
scrnli_24_08_2022_12-33-44
scrnli_24_08_2022_12-33-15

ISCSI
scrnli_24_08_2022_15-16-40

SNMP-v3
scrnli_24_08_2022_15-17-02

SNMP-v2c
scrnli_24_08_2022_15-17-23

Fixes: https://tracker.ceph.com/issues/57284
Signed-off-by: Nizamudeen A nia@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@nizamial09 nizamial09 requested a review from a team as a code owner August 24, 2022 08:11
@nizamial09 nizamial09 requested review from bryanmontalvan and removed request for a team August 24, 2022 08:11
@github-actions github-actions bot added this to In progress in Dashboard Aug 24, 2022
@nizamial09 nizamial09 changed the title mgr/dashboard: fix unable to create ingress unmanaged mgr/dashboard: fix unmanaged service creation Aug 24, 2022
@nizamial09
Copy link
Member Author

@avanthakkar pointed it out to me that apart from the ingress services like iscsi and snmp-gateway faces this issue. so adding the fixes for them too.

@nizamial09 nizamial09 force-pushed the ingress-unmanaged branch 3 times, most recently from 14a6ae2 to 4105a31 Compare August 24, 2022 10:25
Dashboard automation moved this from In progress to Reviewer approved Aug 29, 2022
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

the following snipped is the error from backend

```
 File "/lib/python3.6/site-packages/ceph/deployment/service_spec.py", line 698, in _from_json_impl
                                                  _cls.validate()
                                                File "/lib/python3.6/site-packages/ceph/deployment/service_spec.py", line 1058, in validate
                                                  'Cannot add ingress: No frontend_port specified')
                                              ceph.deployment.hostspec.SpecValidationError: Cannot add ingress: No frontend_port specified
```

It looks like even if we set unmanaged flag, we need to input the
backend_service, frontend_port, monitor_port and virtual_ip, because there is a
validation going for that in the backend.

https://github.com/ceph/ceph/blob/main/src/python-common/ceph/deployment/service_spec.py#L1050

Fixes: https://tracker.ceph.com/issues/57284
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

1 similar comment
@aaSharma14
Copy link
Contributor

jenkins test dashboard cephadm

@epuertat
Copy link
Member

epuertat commented Sep 2, 2022

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test windows

@nizamial09
Copy link
Member Author

the applitools is failing after several retries and accepting https://jenkins.ceph.com/job/ceph-dashboard-pull-requests/11648/

Error: Eyes-Cypress detected diffs or errors during execution of visual tests. See details at: https://eyes.applitools.com/app/batches/00000251739600734755/00000251739600734614?accountId=hCTedwnSTUWSCZlXPqua0g~~
       Passed - 4 tests
         ✓ Login Component Check [1920x1080]
         ✓ Login Component Check [1920x1080]
         ✓ Login Component Check [800x600]
         ✓ Login Component Check [800x600]
       Diffs detected - 4 tests
         ⚠ Dashboard Component [1920x1080]
         ⚠ Dashboard Component [1920x1080]
         ⚠ Dashboard Component [800x600]
         ⚠ Dashboard Component [800x600]

       See details at: https://eyes.applitools.com/app/batches/00000251739600734755/00000251739600734614?accountId=hCTedwnSTUWSCZlXPqua0g~~


    at /home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/@applitools/eyes-cypress/src/plugin/waitForBatch.js:26:13
    at runMicrotasks (<anonymous>:null:null)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.handler (/home/jenkins-build/build/workspace/ceph-dashboard-pull-requests/src/pybind/mgr/dashboard/frontend/node_modules/@applitools/eyes-cypress/src/plugin/hooks.js:35:7)

@nizamial09 nizamial09 merged commit 0a60e89 into ceph:main Sep 9, 2022
11 of 13 checks passed
Dashboard automation moved this from Reviewer approved to Done Sep 9, 2022
@nizamial09 nizamial09 deleted the ingress-unmanaged branch September 9, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Dashboard
  
Done
4 participants