New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: civetweb should use unique request id #4780

Merged
merged 1 commit into from Jun 2, 2015

Conversation

Projects
None yet
3 participants
@oritwas
Contributor

oritwas commented May 27, 2015

http://tracker.ceph.com/issues/11720

max_req_id was moved to RGWRados and changed to atomic64_t.

The same request id resulted in gc giving the same idtag to all objects
resulting in a leakage of rados objects. It only kept the last deleted object in
it's queue, the previous objects were never freed.

Fixes: 10295
Backport: Hammer, Firefly

Signed-off-by: Orit Wasserman owasserm@redhat.com
(cherry picked from commit c262259)

Conflicts:
src/rgw/rgw_main.cc
src/rgw/rgw_rados.h

@yehudasa yehudasa added this to the firefly milestone May 27, 2015

@oritwas

This comment has been minimized.

Contributor

oritwas commented May 27, 2015

good catch , fixed it

rgw: civetweb should use unique request id
max_req_id was moved to RGWRados and changed to atomic64_t.

The same request id resulted in gc giving the same idtag to all objects
resulting in a leakage of rados objects. It only kept the last deleted object in
it's queue, the previous objects were never freed.

Fixes: 10295
Backport: Hammer, Firefly

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
(cherry picked from commit c262259)

Conflicts:
	src/rgw/rgw_main.cc
	src/rgw/rgw_rados.h
@yehudasa

This comment has been minimized.

Member

yehudasa commented May 28, 2015

@oritwas looks good, maybe we should make some sanity check to validate it's actually working?

@oritwas

This comment has been minimized.

Contributor

oritwas commented May 29, 2015

run s3 tests all ok except version tests

----- Original Message -----

From: "Yehuda Sadeh" notifications@github.com
To: "ceph/ceph" ceph@noreply.github.com
Cc: "Orit Wasserman" owasserm@redhat.com
Sent: Thursday, May 28, 2015 1:30:49 PM
Subject: Re: [ceph] rgw: civetweb should use unique request id (#4780)

@oritwas looks good, maybe we should make some sanity check to validate it's
actually working?


Reply to this email directly or view it on GitHub:
#4780 (comment)

yehudasa added a commit that referenced this pull request Jun 2, 2015

Merge pull request #4780 from oritwas/wip-10295-firefly
rgw: civetweb should use unique request id

Reviewd-by: Yehuda Sadeh <yehuda@rehat.com>

@yehudasa yehudasa merged commit 819cf6d into ceph:firefly Jun 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment