Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Cycles.cc: skip initialization if rdtsc is not implemented #4839

Merged
merged 1 commit into from Jun 4, 2015

Conversation

@b-ranto
Copy link
Contributor

b-ranto commented Jun 3, 2015

The Cycles initialization gets stuck in infinite loop if rdtsc is not
implemented. This patch fixes the issue by quitting the initialization
if rtdsc fails.

The patch was cherry-picked from ubuntu patch by James Page, see

https://bugzilla.redhat.com/show_bug.cgi?id=1222286

for more details on the patch.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jun 3, 2015

@branto1 we might need a Sign-off-by: from James. @javacruft are you okay with it? thank you =)

@b-ranto

This comment has been minimized.

Copy link
Contributor Author

b-ranto commented Jun 3, 2015

@javacruft: Feel free to post your own PR, I just want to see the patch merged upstream so that it won't bite us again in the future . :) Or alternatively, I can modify the commit message and add your sign-off-by line there if you're ok with that?

@javacruft

This comment has been minimized.

Copy link
Contributor

javacruft commented Jun 4, 2015

+1 I'm fine with this.

The Cycles initialization gets stuck in infinite loop if rdtsc is not
implemented. This patch fixes the issue by quitting the initialization
if rtdsc fails.

The patch was cherry-picked from ubuntu patch by James Page, see

https://bugzilla.redhat.com/show_bug.cgi?id=1222286

for more details on the patch.

Signed-off-by: James Page <james.page@ubuntu.com>
@b-ranto b-ranto force-pushed the wip-fix-arm-linking-issue branch from 1cc76d3 to 35c5fd0 Jun 4, 2015
@b-ranto

This comment has been minimized.

Copy link
Contributor Author

b-ranto commented Jun 4, 2015

ok, I've amended the commit message to include your 'sign-off'.

@yuyuyu101

This comment has been minimized.

Copy link
Member

yuyuyu101 commented Jun 4, 2015

LGTM

liewegas added a commit that referenced this pull request Jun 4, 2015
common/Cycles.cc: skip initialization if rdtsc is not implemented

Reviewed-by: Boris Ranto <branto@redhat.com>
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
@liewegas liewegas merged commit 5ff8056 into master Jun 4, 2015
@liewegas liewegas deleted the wip-fix-arm-linking-issue branch Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.