mgr/dashboard: Unable to change rgw subuser permission #48412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pereman2
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
dashboard/__init__.py:60: note: ... from here:
dashboard/controllers/rgw.py: note: In member "create_subuser" of class "RgwUser":
dashboard/controllers/rgw.py:510: error: Argument 1 to "loads" has incompatible type "Dict[Any, Any]"; expected "Union[str, bytes]"
aaSharma14
force-pushed
the
fix-rgw-subuser-permissions
branch
3 times, most recently
from
4235c74
to
4ff3b18
Compare
|
jenkins test make check |
|
jenkins test make check arm64 |
aaSharma14
force-pushed
the
fix-rgw-subuser-permissions
branch
from
4ff3b18
to
b242a92
Compare
avanthakkar
reviewed
Oct 10, 2022
There was a problem hiding this comment.
@aaSharma14 Can you add unit tests? I think we don't have tests for checking subuser create/edit (also in frontend), so would be good to have them!
aaSharma14
force-pushed
the
fix-rgw-subuser-permissions
branch
from
b242a92
to
69efe66
Compare
aaSharma14
force-pushed
the
fix-rgw-subuser-permissions
branch
from
69efe66
to
51f54dd
Compare
nizamial09
reviewed
Oct 11, 2022
Tried to edit the permission of a subuser but once changed the permission, edited permission not seen in user info of UI(ceph dashboard) and from CLI as well Fixes:https://tracker.ceph.com/issues/57805 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
aaSharma14
force-pushed
the
fix-rgw-subuser-permissions
branch
from
51f54dd
to
0b3bdbb
Compare
nizamial09
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to edit the permission of a subuser but once changed the permission, edited permission not seen in user info of UI(ceph dashboard) and from CLI as well
https://tracker.ceph.com/issues/57805
Signed-off-by:Aashish Sharmaaasharma@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows