New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: missing man pages for ceph-create-keys, ceph-disk-* #4846

Merged
2 commits merged into from Jun 15, 2015

Conversation

Projects
None yet
5 participants
@smithfarm
Contributor

smithfarm commented Jun 3, 2015

@smithfarm smithfarm added this to the hammer milestone Jun 3, 2015

@smithfarm smithfarm self-assigned this Jun 3, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jun 3, 2015

@tchaikov can you take a look?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 3, 2015

once it is also added into the rpm spec file. and confirmed by the gitbuilders. Reviewed-by.

@smithfarm i'd suggest you to push it to a wip branch to get it tested with the tireless builders.

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jun 3, 2015

@tchaikov: I noticed that http://tracker.ceph.com/issues/10725 is asking for 4 manpages, but it looks like you resolved it after adding only this one . . . (?) Should we open issues for the remaining 3?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 3, 2015

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jun 3, 2015

@tchaikov I think the make-check bot is paused, see Loic's email to ceph-devel delivered to me today 2015-06-03 at 01:48 CEST.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 3, 2015

@tchaikov I think the make-check bot is paused, see Loic's email to ceph-devel delivered to me today 2015-06-03 at 01:48 CEST.

okay. would you mind pushing it to ceph repo to get it built by gitbuilders?

:program:`ceph-create-keys` is a utility to generate bootstrap keyrings using
the given monitor when it is ready.
it creates following auth entities (or users)

This comment has been minimized.

@theanalyst

theanalyst Jun 3, 2015

Member

Possibly It

This comment has been minimized.

@theanalyst

theanalyst Jun 3, 2015

Member

Sorry didn't notice that this was a backport PR.. Guess it should be fine either way

This comment has been minimized.

@tchaikov

tchaikov Jun 3, 2015

Contributor

@theanalyst might be a chance to fix it though. we could add a note in the commit message for this small edit.

This comment has been minimized.

@ktdreyer

ktdreyer Jun 3, 2015

Member

as long as it gets fixed in master too so it doesn't get lost :)

This comment has been minimized.

@ktdreyer

ktdreyer Jun 3, 2015

Member

... or should I say "It" doesn't get lost! 😆

This comment has been minimized.

@tchaikov

tchaikov added a commit to tchaikov/ceph that referenced this pull request Jun 4, 2015

man/create-create-keys: minor fixes
to address the comments on ceph#4846

Signed-off-by: Kefu Chai <kchai@redhat.com>

tchaikov added a commit to tchaikov/ceph that referenced this pull request Jun 4, 2015

man/create-create-keys: minor fixes
to address the comments on ceph#4846

Fixes: ceph#10725
Signed-off-by: Kefu Chai <kchai@redhat.com>
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jun 4, 2015

@tchaikov: rebased to include fixes from #4855

@smithfarm smithfarm added documentation and removed build/ops labels Jun 4, 2015

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 4, 2015

@smithfarm i am sure if i follow you, but the cherry-pick from 27cee2f is missing some bits bit:
SUSE@27cee2f#diff-ca40628478ff1274b73dcd40c384e7f0R640

joaquimrocha added a commit to joaquimrocha/ceph that referenced this pull request Jun 5, 2015

man/create-create-keys: minor fixes
to address the comments on ceph#4846

Fixes: ceph#10725
Signed-off-by: Kefu Chai <kchai@redhat.com>

joaquimrocha added a commit to joaquimrocha/ceph that referenced this pull request Jun 5, 2015

man/create-create-keys: minor fixes
to address the comments on ceph#4846

Fixes: ceph#10725
Signed-off-by: Kefu Chai <kchai@redhat.com>

tchaikov and others added some commits Apr 21, 2015

doc: add ceph-create-keys.8
Fixes: #10725
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 27cee2f)

Conflicts:
    doc/man/8/ceph-create-keys.rst
    Includes fixes from #4855
man/ceph-create-keys.8: add missing file
This is the generated manpage, taken from a local build of master

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit bcda61f)
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jun 6, 2015

@tchaikov: added the missing bit in ceph.spec.in - what else is missing?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 6, 2015

@smithfarm no, thanks! Reviewed-by: Kefu Chai <kchai@redhat.com> and also i pushed to ceph.git/wip-4846, the rpm builders are good.

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Jun 8, 2015

LGTM

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

ghost pushed a commit that referenced this pull request Jun 15, 2015

Loic Dachary
Merge pull request #4846 from SUSE/wip-11862-hammer
missing man pages for ceph-create-keys, ceph-disk-*

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>

@ghost ghost merged commit 70bba62 into ceph:hammer Jun 15, 2015

@smithfarm smithfarm deleted the SUSE:wip-11862-hammer branch Jun 15, 2015

@ghost ghost changed the title from missing man pages for ceph-create-keys, ceph-disk-* to doc: missing man pages for ceph-create-keys, ceph-disk-* Aug 4, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment