quincy: src/mds: increment directory inode's change attr by one #48520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternate operations that only change directory's ctime (setattr/setxattr/removexattr on directory) with those that change directory's mtime and ctime (create/rename/remove a file within directory). Check that directory's change_attr is updated everytime ctime changes. Signed-off-by: Ramana Raja <rraja@redhat.com> (cherry picked from commit d597100)
... whenever the mtime or ctime of the directory inode is modified. In CephFS subvolume clones exported using NFS-Ganesha, newly created files using `touch` were not being listed. It was identified that the create request sent to the Ceph MDS via NFS-Ganesha's libcephfs client modified the mtime and ctime of the parent directory, but did not modify the change_attr of the parent directory. Since the NFS client didn't see a modification of the change attribute in the reply, it didn't invalidate its readdir cache. The subsequent directory `ls` was satisfied from the NFS client's stale readdir cache. Whenever parent directory inode's mtime was modified in MDCache::predirty_journal_parents(), the parent inode's change_attr was set to its dirstat->change_attr. The parent inode's dirstat->change_attr doesn't track changes to parent's *ctime only* changes such as setattr, setvxattr, etc. on the parent directory. See commit 0d441dc for more details. This caused the directory inode's change_attr to not be updated when an operation to change only its ctime was followed by an operation to change its mtime and ctime. Fix this by making changes to MDCache::predirty_journal_parents() and CInode::finish_scatter_gather_update() to increment the directory inode's change_attr by one instead of setting it to its dirstat->change_attr. Fixes: https://tracker.ceph.com/issues/57210 Signed-off-by: Ramana Raja <rraja@redhat.com> (cherry picked from commit 05fdd6c)
Signed-off-by: Ramana Raja <rraja@redhat.com> (cherry picked from commit f02b777)
kotreshhr
approved these changes
Oct 18, 2022
|
jenkins test make check |
|
jenkins test windows |
1 similar comment
|
jenkins test windows |
joscollin
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/57879
backport of #48241
parent tracker: https://tracker.ceph.com/issues/57210
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh