mgr/dashboard: fix CephPGImbalance alert #48525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaSharma14
requested review from
avanthakkar and
Pegonzal
and removed request for
a team
aaSharma14
force-pushed
the
fix-PgImbalance-alert
branch
from
21dc55c
to
0a6219e
Compare
nizamial09
reviewed
Oct 31, 2022
...rd/frontend/src/app/ceph/cluster/prometheus/active-alert-list/active-alert-list.component.ts
Outdated
Show resolved
Hide resolved
...rd/frontend/src/app/ceph/cluster/prometheus/active-alert-list/active-alert-list.component.ts
Outdated
Show resolved
Hide resolved
|
Same as with the other PR @aaSharma14: no PR/commit should start with "Fix..." if a tracker defect report is not attached along with it. "Fix" implies bug, hence backporting to the active releases according to the Ceph bugfixing policy. Additionally, having a tracker will simplify the backporting paperwork. |
aaSharma14
force-pushed
the
fix-PgImbalance-alert
branch
4 times, most recently
from
1514090
to
30b36d9
Compare
s0nea
reviewed
Nov 16, 2022
nizamial09
approved these changes
Nov 21, 2022
aaSharma14
force-pushed
the
fix-PgImbalance-alert
branch
3 times, most recently
from
91613ae
to
fdbb492
Compare
Donot show the CephPgImbalance alert if the balancer shows no optimization required Fixes: https://tracker.ceph.com/issues/55568 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
aaSharma14
force-pushed
the
fix-PgImbalance-alert
branch
from
fdbb492
to
a75792d
Compare
|
jenkins test signed |
|
jenkins test dashboard |
This was referenced Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CephPGImbalance might be inaccurate in some specific environments. The CephPGImbalance alert is going to be raised, if the amount of PGs of an OSD is 30% less than the average amount of PGs of all OSDs. The amount of PGs of an OSD is normally related to e.g. number of OSDs and size or class of device. For a well-functioning cluster the Balancer takes care of balancing the PGs.
In some cases e.g. if the cluster consists of a lot of bigger HDDs and some smaller SSDs, the alert might be raised. Although the configuration and balance of the PGs is handled correctly.
Fixes: https://tracker.ceph.com/issues/55568
Signed-off-by: Aashish Sharma aasharma@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows