New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Fix CephPoolGrowthWarning alert #48526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aaSharma14 , the commit isn't signed
|
@aaSharma14 can you add a tracker for it? also could you explain in the description why the error happened and how the fix actually fixed the issue? (not clearly understanding since i've no clue in monitoring queries). |
Agree, that's exactly the first thing that came to my mind: what's that "error" and, given it feels like a bug, what releases is this reproduced in? |
8e17054
to
7cc9923
Compare
|
jenkins retest this please |
|
@aaSharma14 the signed-off-by check is failing. maybe its because you missed a space after the colon. |
Prometheus reports an error - many-to-many matching not allowed: matching labels must be unique on one side for CephPoolGrowthWarning if we have same pool ids on two different instances. Fixes: https://tracker.ceph.com/issues/58017 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
7cc9923
to
97189b6
Compare
|
jenkins test make check |
|
jenkins test api |
|
jenkins test dashboard |
Prometheus reports an error - many-to-many matching not allowed: matching labels must be unique on one side for CephPoolGrowthWarning if we have same pool ids on two different instances.
Fixes: https://tracker.ceph.com/issues/58017
Signed-off-by: Aashish Sharma aasharma@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows