Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Fix CephPoolGrowthWarning alert #48526

Merged
merged 1 commit into from Nov 29, 2022

Conversation

aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented Oct 18, 2022

Prometheus reports an error - many-to-many matching not allowed: matching labels must be unique on one side for CephPoolGrowthWarning if we have same pool ids on two different instances.

Fixes: https://tracker.ceph.com/issues/58017
Signed-off-by: Aashish Sharma aasharma@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@aaSharma14 aaSharma14 requested a review from a team as a code owner October 18, 2022 11:14
@aaSharma14 aaSharma14 requested review from torchiaf and Pegonzal and removed request for a team October 18, 2022 11:14
Copy link
Contributor

@Pegonzal Pegonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aaSharma14 , the commit isn't signed

@nizamial09
Copy link
Member

@aaSharma14 can you add a tracker for it? also could you explain in the description why the error happened and how the fix actually fixed the issue? (not clearly understanding since i've no clue in monitoring queries).

@epuertat
Copy link
Member

@aaSharma14 can you add a tracker for it? also could you explain in the description why the error happened and how the fix actually fixed the issue? (not clearly understanding since i've no clue in monitoring queries).

Agree, that's exactly the first thing that came to my mind: what's that "error" and, given it feels like a bug, what releases is this reproduced in?

@aaSharma14 aaSharma14 force-pushed the fix-cephPoolGrowth-alert branch 3 times, most recently from 8e17054 to 7cc9923 Compare November 14, 2022 10:18
@nizamial09
Copy link
Member

jenkins retest this please

@nizamial09
Copy link
Member

@aaSharma14 the signed-off-by check is failing. maybe its because you missed a space after the colon.
Signed-off-by:Aashish Sharma <aasharma@redhat.com>

Prometheus reports an error - many-to-many matching not allowed: matching labels must be unique on one side for CephPoolGrowthWarning if we have same pool ids on two different instances.

Fixes: https://tracker.ceph.com/issues/58017
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@aaSharma14
Copy link
Contributor Author

jenkins test make check

@nizamial09
Copy link
Member

jenkins test api

@nizamial09
Copy link
Member

jenkins test dashboard

@nizamial09 nizamial09 merged commit 3f1c1b6 into ceph:main Nov 29, 2022
9 of 13 checks passed
@nizamial09 nizamial09 deleted the fix-cephPoolGrowth-alert branch November 29, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants