New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: Clock skew causes missing summary and confuses Calamari #4867

Merged
1 commit merged into from Jul 22, 2015

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Jun 5, 2015

http://tracker.ceph.com/issues/11878

This is a cherry-pick of Thorsten Behren's downstream firefly backport of #3659

@smithfarm smithfarm added this to the firefly milestone Jun 5, 2015

@smithfarm smithfarm self-assigned this Jun 5, 2015

@ghost

This comment has been minimized.

ghost commented Jul 8, 2015

@smithfarm could you please rebase and repush to trigger the bot ?

@ghost ghost changed the title from Clock skew causes missing summary and confuses Calamari to mon: Clock skew causes missing summary and confuses Calamari Jul 21, 2015

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

@jecluis this backport has passed the rados suite ( http://pulpito.ceph.com/loic-2015-07-09_21:09:04-rados-firefly-backports---basic-multi ) do you think it can be merged in firefly ?

@jecluis

This comment has been minimized.

Member

jecluis commented Jul 21, 2015

sorry, I'm not finding 092ef99 in upstream master. Is this a backport directly from suse's repo? is there no corresponding upstream patch?

@ghost

This comment has been minimized.

ghost commented Jul 21, 2015

hum, indeed, that's unexpected. Good catch @jecluis !

Always provide summary for non-healthy cluster.
This fixes a problem, wherein calamari does not provide
popup drill-downs for warnings or errors, should the summary
be missing.

Calamari gets health info from /api/v1/cluster/$FSID/health.
If the data here has a summary field, this summary is provided
in a popup window:

  /api/v1/cluster/$FSID/health is populated (ultimately) with
  status obtained via librados python bindings from the ceph
  cluster. In the case where there's clock skew, the summary
  field supplied by the ceph cluster is empty.

No summary field, no popup window with more health details.

Signed-off-by: Thorsten Behrens <tbehrens@suse.com>
(cherry picked from commit eaf6e0c)

Conflicts:
	src/mon/Monitor.cc
            firefly needs ss
@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Jul 22, 2015

My bad, sorry. Since Thorsten had already done the backport downstream, I cherry-picked from there to avoid extra work. Later I learned this is not allowed, but forgot to go back and re-do this PR.

Rebased to latest firefly and cherry-picked from the master patch.

@jecluis

This comment has been minimized.

Member

jecluis commented Jul 22, 2015

I'm okay with this backport.

ghost pushed a commit that referenced this pull request Jul 22, 2015

Loic Dachary
Merge pull request #4867 from SUSE/wip-11878-firefly
mon: Clock skew causes missing summary and confuses Calamari

Reviewed-by: Joao Eduardo Luis <joao@suse.de>

@ghost ghost merged commit 71174a5 into ceph:firefly Jul 22, 2015

@smithfarm smithfarm deleted the SUSE:wip-11878-firefly branch Jul 22, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment