New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: Clock skew causes missing summary and confuses Calamari #4868

Merged
1 commit merged into from Jul 14, 2015

Conversation

Projects
None yet
5 participants
@smithfarm
Contributor

smithfarm commented Jun 5, 2015

http://tracker.ceph.com/issues/11879

This is a cherry-pick of Thorsten Behren's downstream hammer backport of #3659

@smithfarm smithfarm added this to the hammer milestone Jun 5, 2015

@smithfarm smithfarm self-assigned this Jun 5, 2015

@smithfarm smithfarm assigned theanalyst and unassigned smithfarm Jun 30, 2015

@ghost

This comment has been minimized.

ghost commented Jul 8, 2015

@smithfarm could you please rebase & repush for the bot to run this again ?

Always provide summary for non-healthy cluster
This fixes a problem, wherein calamari does not provide
popup drill-downs for warnings or errors, should the summary
be missing.

Calamari gets health info from /api/v1/cluster/$FSID/health.
If the data here has a summary field, this summary is provided
in a popup window:

  /api/v1/cluster/$FSID/health is populated (ultimately) with
  status obtained via librados python bindings from the ceph
  cluster. In the case where there's clock skew, the summary
  field supplied by the ceph cluster is empty.

No summary field, no popup window with more health details.

Signed-off-by: Thorsten Behrens <tbehrens@suse.com>
(cherry picked from commit eaf6e0c)
@ghost

This comment has been minimized.

ghost commented Jul 10, 2015

@theanalyst Sam merged the matching master pull request, he is the one that should approve merging this one.

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 10, 2015

@athanatos This has passed the first round of integration tests for hammer at tracker.ceph.com/issues/11990#rados do you think it is ready for merge

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jul 14, 2015

This seems fine to me.

ghost pushed a commit that referenced this pull request Jul 14, 2015

Loic Dachary
Merge pull request #4868 from SUSE/wip-11879-hammer
Clock skew causes missing summary and confuses Calamari

Reviewed-by: Samuel Just <sjust@redhat.com>

@ghost ghost merged commit 8753b2b into ceph:hammer Jul 14, 2015

@smithfarm smithfarm deleted the SUSE:wip-11879-hammer branch Jul 14, 2015

@ghost ghost changed the title from Clock skew causes missing summary and confuses Calamari to mon: Clock skew causes missing summary and confuses Calamari Aug 4, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment