Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Replace vonage-status-panel with native grafana stat panel #48783

Merged
merged 1 commit into from Feb 8, 2023

Conversation

aaSharma14
Copy link
Contributor

@aaSharma14 aaSharma14 commented Nov 8, 2022

Before:
Screenshot from 2022-11-08 10-37-06

After:
Screenshot from 2022-11-21 15-17-20

Fixes: https://tracker.ceph.com/issues/58295
Signed-off-by: Aashish Sharmaaasharma@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Copy link
Contributor

@pereman2 pereman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Aasshish thanks for helping here :).

I believe the alignment should be addressed as it is looking too out of place and different in each label.

Active and standy should have the number below as the previous stat panels, furthermore, could it help aligning to center both labels and values maybe?

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reall nice. BTW I thought that this panel was also generated from a jsonnet/grafonnet file... Not the case?

@aaSharma14
Copy link
Contributor Author

Looks reall nice. BTW I thought that this panel was also generated from a jsonnet/grafonnet file... Not the case?

Thanks @epuertat , ceph-cluster.json is the only dashboard json file for which we didn't create a jsonnet file.

@aaSharma14
Copy link
Contributor Author

Great job Aasshish thanks for helping here :).

I believe the alignment should be addressed as it is looking too out of place and different in each label.

Active and standy should have the number below as the previous stat panels, furthermore, could it help aligning to center both labels and values maybe?

Thanks @pereman2 , I have modified the panels a bit with added bg color as well, couldn't find the properties to set the alignment though, anyways it looks a little better to me than before.

Copy link
Member

@nizamial09 nizamial09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great @aaSharma14 , thank you!

@nizamial09
Copy link
Member

nizamial09 commented Nov 22, 2022

you have a singed-off-by check here as well. Its best to sign the commits using git commit -s --amend if you are not doing that already.

@aaSharma14
Copy link
Contributor Author

jenkins retest this please

@aaSharma14 aaSharma14 merged commit 3063c8a into ceph:main Feb 8, 2023
14 of 17 checks passed
@aaSharma14 aaSharma14 deleted the fix-grafana-stat-panel branch February 8, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants