New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: OPT_INT option interprets 3221225472 as -1073741824, and crashes in Throttle::Throttle() #4889

Merged
2 commits merged into from Jul 10, 2015

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented Jun 7, 2015

tchaikov added some commits Apr 29, 2015

common/config: detect overflow of int values
* #include "strtol.h" in strtol.cc, to ensure the function defintions
  are consistent.
* add a test accordingly
* fix the testcase of converting 1024E.
* do not accept integers overflow after adding SI suffix
* do not accept integers underflow (i.e. negative values)

Fixes: #11484
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit d62f80d)
common/config: detect overflow of float values
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 1ff409e)

@theanalyst theanalyst self-assigned this Jun 7, 2015

@theanalyst theanalyst added this to the hammer milestone Jun 7, 2015

@ghost

This comment has been minimized.

ghost commented Jun 7, 2015

@theanalyst if I'm not mistaken the issue in the pull request description should be http://tracker.ceph.com/issues/11738 instead of http://tracker.ceph.com/issues/11484

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jun 7, 2015

@dachary Both the descriptions look the same to me.. though I guess it should have been #4494 's title

@ghost

This comment has been minimized.

ghost commented Jun 7, 2015

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jun 7, 2015

Yes.. sorry.. updated

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 6, 2015

@athanatos / @tchaikov this has passed the first round of integration tests for hammer backports at http://tracker.ceph.com/issues/11990#rados Do you think it is ready to merge

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 10, 2015

👍

ghost pushed a commit that referenced this pull request Jul 10, 2015

Loic Dachary
Merge pull request #4889 from theanalyst/wip-11484-hammer
OPT_INT option interprets 3221225472 as -1073741824, and crashes in Throttle::Throttle()

Reviewed-by: Kefu Chai <kchai@redhat.com>

@ghost ghost merged commit 5527720 into ceph:hammer Jul 10, 2015

@ghost ghost changed the title from OPT_INT option interprets 3221225472 as -1073741824, and crashes in Throttle::Throttle() to common: OPT_INT option interprets 3221225472 as -1073741824, and crashes in Throttle::Throttle() Aug 4, 2015

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment