New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: take crashes due to invalid arg #4891

Merged
2 commits merged into from Jul 15, 2015

Conversation

Projects
None yet
4 participants
@theanalyst
Member

theanalyst commented Jun 7, 2015

liewegas added some commits May 12, 2015

crush: fix crash from invalid 'take' argument
Verify that the 'take' argument is a valid device or bucket.  Otherwise,
ignore it (do not add the value to the working vector).

Backport: hammer, firefly
Fixes: #11602
Reported-by: shiva rkreddy <shiva.rkreddy@gmail.com>
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 9324d0a)
mon: prevent bucket deletion when referenced by a rule
If a rule references a bucket with 'take', prevent deletion.

Fixes: #11602
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 3d591af)

@theanalyst theanalyst self-assigned this Jun 7, 2015

@theanalyst theanalyst added this to the hammer milestone Jun 7, 2015

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 10, 2015

@athanatos / @liewegas This has passed the first round of integration tests for hammer at http://tracker.ceph.com/issues/11990#rados Do you think it is ready for merge ?

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jul 14, 2015

This one you should run by @tchaikov , I think.

ghost pushed a commit that referenced this pull request Jul 15, 2015

Loic Dachary
Merge pull request #4891 from theanalyst/wip-11740-hammer
crush: take crashes due to invalid arg

Reviewed-by: Loic Dachary <ldachary@redhat.com>

@ghost ghost merged commit daf5450 into ceph:hammer Jul 15, 2015

ghost pushed a commit that referenced this pull request Jul 15, 2015

Merge pull request #4891: crush: take crashes due to invalid arg
Reviewed-by: Loic Dachary <ldachary@redhat.com>

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment