mgr/dashboard: Add metric relative to osd blocklist #49049
Conversation
It would be good to have a metric with number of clients "blocklisted" of command: "ceph osd blocklist ls". The reason to have this is metric is have an alert when this number raise up. Fixes: https://tracker.ceph.com/issues/58083 Signed-off-by: Aashish Sharma <aasharma@redhat.com>
aaSharma14
requested review from
s0nea,
avanthakkar,
epuertat and
nizamial09
|
jenkins test make check |
And can you create maybe tracker for adding any alerts related to this metric. |
|
jenkins retest this please |
|
jenkins test make check |
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
|
jenkins test make check arm64 |
|
jenkins test windows |
| @@ -66,9 +66,10 @@ def health_status_to_number(status: str) -> int: | |||
| return 2 | |||
| raise ValueError(f'unknown status "{status}"') | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
weird. how come this change passed the run-tox-mgr test?
| @profile_method() | ||
| def get_osd_blocklisted_entries(self) -> None: | ||
| r = self.mon_command({ | ||
| 'prefix': 'osd blocklist ls', | ||
| 'format': 'json' | ||
| }) |
There was a problem hiding this comment.
@aaSharma14 can't we pick this value from an existing cached mgr map?
If not, what about extending one of the maps to cache this new metadata?
The whole idea of the ceph-mgr is to avoid mgr-modules from interacting with the ceph-mon, so that, for read-only stuff, ceph-mgr basically shields the core Ceph cluster from the workload generated by the mgr-modules.
It would be good to have a metric with number of clients "blocklisted" of command: "ceph osd blocklist ls". The reason to have this is metric is have an alert when this number raise up.
Fixes: https://tracker.ceph.com/issues/58083
Signed-off-by: Aashish Sharma aasharma@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows